Bug 131086 - Load Media Controls js/css from bundle
Summary: Load Media Controls js/css from bundle
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Blocks: 131194
  Show dependency treegraph
Reported: 2014-04-01 17:43 PDT by Dean Jackson
Modified: 2014-04-03 17:03 PDT (History)
9 users (show)

See Also:

Patch (13.50 KB, patch)
2014-04-01 17:46 PDT, Dean Jackson
eric.carlson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (581.09 KB, application/zip)
2014-04-01 18:39 PDT, Build Bot
no flags Details
Patch (13.53 KB, patch)
2014-04-02 14:03 PDT, Dean Jackson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-04-01 17:43:25 PDT
On Mac/iOS we should load the mediaControls*.{js,css} files from the bundle rather than inserting encoded versions into the C source code.
Comment 1 Radar WebKit Bug Importer 2014-04-01 17:44:45 PDT
Comment 2 Dean Jackson 2014-04-01 17:46:11 PDT
Created attachment 228349 [details]
Comment 3 Build Bot 2014-04-01 18:39:26 PDT
Comment on attachment 228349 [details]

Attachment 228349 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6493476329881600

New failing tests:
Comment 4 Build Bot 2014-04-01 18:39:29 PDT
Created attachment 228356 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Dean Jackson 2014-04-02 11:26:02 PDT
Thanks. I'll upload one more patch to check EWS. The failure report wasn't very helpful - just said that something before that media test failed.

When I run it locally on WK2 everything passes.
Comment 6 Dean Jackson 2014-04-02 14:03:09 PDT
Created attachment 228427 [details]
Comment 7 Dean Jackson 2014-04-02 14:44:56 PDT
Committed r166669: <http://trac.webkit.org/changeset/166669>