Bug 131173 - Web Inspector: add entries for probe samples in the JS/Events timeline UI
Summary: Web Inspector: add entries for probe samples in the JS/Events timeline UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Katie Madonna
URL:
Keywords: InRadar
Depends on: 131127
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-03 11:09 PDT by Brian Burg
Modified: 2014-04-18 14:22 PDT (History)
6 users (show)

See Also:


Attachments
ProbeSampleFired events in the main timeline view. (80.13 KB, image/png)
2014-04-17 16:47 PDT, Katie Madonna
no flags Details
ProbeSampleFired event selected view. (289.01 KB, image/png)
2014-04-17 16:48 PDT, Katie Madonna
no flags Details
Patch (7.29 KB, patch)
2014-04-17 16:50 PDT, Katie Madonna
no flags Details | Formatted Diff | Diff
Patch (10.43 KB, patch)
2014-04-18 13:41 PDT, Katie Madonna
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-03 11:09:44 PDT
UI work for 131127.
Comment 1 Radar WebKit Bug Importer 2014-04-03 11:10:18 PDT
<rdar://problem/16514032>
Comment 2 Radar WebKit Bug Importer 2014-04-03 11:10:23 PDT
<rdar://problem/16514035>
Comment 3 Katie Madonna 2014-04-17 16:47:24 PDT
Created attachment 229595 [details]
ProbeSampleFired events in the main timeline view.
Comment 4 Katie Madonna 2014-04-17 16:48:03 PDT
Created attachment 229596 [details]
ProbeSampleFired event selected view.
Comment 5 Katie Madonna 2014-04-17 16:50:36 PDT
Created attachment 229597 [details]
Patch
Comment 6 Timothy Hatcher 2014-04-17 17:38:16 PDT
Comment on attachment 229597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229597&action=review

Looking good. Missing the icon file.

> Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:218
> +        return WebInspector.UIString("Probe Sample Fired");

I think “Probe Sample Recorded” or “Probe Fired” would be better.

> Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css:79
> +    content: url(../Images/TimelineRecordProbeSampled.svg);

I don't see the icon added in the patch. Forget svn/git add?
Comment 7 Katie Madonna 2014-04-18 13:41:13 PDT
Created attachment 229672 [details]
Patch
Comment 8 Timothy Hatcher 2014-04-18 13:44:47 PDT
Comment on attachment 229672 [details]
Patch

Looks good!
Comment 9 WebKit Commit Bot 2014-04-18 14:22:07 PDT
Comment on attachment 229672 [details]
Patch

Clearing flags on attachment: 229672

Committed r167509: <http://trac.webkit.org/changeset/167509>
Comment 10 WebKit Commit Bot 2014-04-18 14:22:12 PDT
All reviewed patches have been landed.  Closing bug.