Bug 131127 - Web Inspector: hook up probe samples to TimelineAgent's records
Summary: Web Inspector: hook up probe samples to TimelineAgent's records
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
Keywords: InRadar
Depends on:
Blocks: 131173
  Show dependency treegraph
Reported: 2014-04-02 14:01 PDT by Brian Burg
Modified: 2014-04-04 22:54 PDT (History)
5 users (show)

See Also:

the patch (13.85 KB, patch)
2014-04-03 18:13 PDT, Brian Burg
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-02 14:01:09 PDT
Katie and I are unsure whether to put probes+console messages into its own timeline category, or to fold it into the JavaScript & Events category. Our first step is to prototype the latter to see how it would work.
Comment 1 Radar WebKit Bug Importer 2014-04-02 14:02:06 PDT
Comment 2 Brian Burg 2014-04-03 11:09:57 PDT
Narrowing this bug just to hooking up the backend. Katie will tackle the frontend part.
Comment 3 Brian Burg 2014-04-03 18:13:46 PDT
Created attachment 228568 [details]
the patch
Comment 4 Timothy Hatcher 2014-04-04 12:29:07 PDT
Comment on attachment 228568 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228568&action=review

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:275
> +            case TimelineAgent.EventType.ProbeSample:
> +                break;

FIXME comment here would be nice.
Comment 5 Brian Burg 2014-04-04 22:54:16 PDT
Committed r166827: <http://trac.webkit.org/changeset/166827>