Bug 131055 - Eliminate HTMLFormElement::m_shouldSubmit
Summary: Eliminate HTMLFormElement::m_shouldSubmit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-01 13:43 PDT by Alexey Proskuryakov
Modified: 2014-04-03 23:19 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (4.11 KB, patch)
2014-04-01 13:50 PDT, Alexey Proskuryakov 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-04-01 13:43:31 PDT 
HTMLFormElement::m_shouldSubmit is confusing an unnecessary.
Comment 1 Alexey Proskuryakov 2014-04-01 13:50:25 PDT 
Created attachment 228315 [details]
proposed patch
Comment 2 Tim Horton 2014-04-01 14:15:03 PDT 
Comment on attachment 228315 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228315&action=review

> Source/WebCore/ChangeLog:9
> +        - as a return value in a funciton whose return value is ignored by all callers;

funciton
Comment 3 Alexey Proskuryakov 2014-04-01 14:57:49 PDT 
Committed <http://trac.webkit.org/r166615>.
Comment 4 mitz 2014-04-03 23:19:42 PDT 
(In reply to comment #3)
> Committed <http://trac.webkit.org/r166615>.

See bug 131212.