Bug 130867 - Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
Summary: Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Blocks: 112840
  Show dependency treegraph
Reported: 2014-03-27 15:14 PDT by Filip Pizlo
Modified: 2014-04-29 14:45 PDT (History)
11 users (show)

See Also:

the patch (9.53 KB, patch)
2014-03-27 15:14 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (9.55 KB, patch)
2014-03-27 15:18 PDT, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-03-27 15:14:05 PDT
Comment 1 Filip Pizlo 2014-03-27 15:14:59 PDT
Created attachment 227991 [details]
the patch
Comment 2 WebKit Commit Bot 2014-03-27 15:18:06 PDT
Attachment 227991 [details] did not pass style-queue:

ERROR: Tools/ChangeLog:3:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ChangeLog:3:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2014-03-27 15:18:33 PDT
Created attachment 227993 [details]
the patch
Comment 4 Mark Hahnenberg 2014-03-27 15:23:05 PDT
Comment on attachment 227993 [details]
the patch

Comment 5 Filip Pizlo 2014-03-27 17:48:47 PDT
Landed in http://trac.webkit.org/changeset/166386
Comment 6 Filip Pizlo 2014-03-27 17:49:14 PDT
This broke builds, will revert.
Comment 7 Filip Pizlo 2014-03-27 17:52:47 PDT
Rolled out in http://trac.webkit.org/changeset/166390
Comment 8 Filip Pizlo 2014-04-29 14:45:51 PDT
Relanded in http://trac.webkit.org/changeset/167671