130546 – FTL ValueToInt32 mishandles the constant case, and by the way, there is a constant case that the FTL sees

Bug 130546 - FTL ValueToInt32 mishandles the constant case, and by the way, there is a constant case that the FTL sees

Summary: FTL ValueToInt32 mishandles the constant case, and by the way, there is a con...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Filip Pizlo

URL:
Keywords:

Depends on:
Blocks:	112840
	Show dependency tree / graph

Reported:	2014-03-20 16:55 PDT by Filip Pizlo
Modified:	2014-03-20 17:33 PDT (History)
CC List:	9 users (show)

See Also:

Attachments
the patch (9.66 KB, patch) 2014-03-20 17:01 PDT, Filip Pizlo	mhahnenberg: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Filip Pizlo 2014-03-20 16:55:21 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2014-03-20 17:01:17 PDT

Created attachment 227356 [details]
the patch

Comment 2 WebKit Commit Bot 2014-03-20 17:04:04 PDT

Attachment 227356 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3904:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3906:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3908:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3912:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3921:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3925:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3927:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3929:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3936:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 9 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Mark Hahnenberg 2014-03-20 17:04:15 PDT

Comment on attachment 227356 [details]
the patch

r=me

Comment 4 Mark Hahnenberg 2014-03-20 17:05:09 PDT

(In reply to comment #2)
> Attachment 227356 [details] did not pass style-queue:
> 
> 
> ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3904:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3906:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3908:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3912:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3921:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3925:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3927:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3929:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3936:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> Total errors found: 9 in 5 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Modulo style.

Comment 5 Filip Pizlo 2014-03-20 17:07:07 PDT

(In reply to comment #4)
> (In reply to comment #2)
> > Attachment 227356 [details] [details] did not pass style-queue:
> > 
> > 
> > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3904:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3906:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3908:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3912:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3921:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3925:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3927:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3929:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3936:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> > Total errors found: 9 in 5 files
> > 
> > 
> > If any of these errors are false positives, please file a bug against check-webkit-style.
> 
> Modulo style.

Yup. :-)

Comment 6 Filip Pizlo 2014-03-20 17:33:22 PDT

Landed in http://trac.webkit.org/changeset/166030