Bug 130506 - [EFL] Add ARM64 build support
Summary: [EFL] Add ARM64 build support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 130453 130454 130500 130502
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-20 05:59 PDT by Gabor Rapcsanyi
Modified: 2014-03-26 00:29 PDT (History)
12 users (show)

See Also:

Attachments
proposed patch (4.18 KB, patch)
2014-03-20 06:35 PDT, Gabor Rapcsanyi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Rapcsanyi 2014-03-20 05:59:27 PDT 
Add ARM64 build support to EFL port.
Comment 1 Gabor Rapcsanyi 2014-03-20 06:35:24 PDT 
Created attachment 227285 [details]
proposed patch
Comment 2 Gyuyoung Kim 2014-03-24 16:38:36 PDT 
Comment on attachment 227285 [details]
proposed patch

rs=me. However, it would be nicer if JS guys take a final look before landing.
Comment 3 Zoltan Herczeg 2014-03-25 05:46:49 PDT 
Comment on attachment 227285 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227285&action=review

> Source/WTF/wtf/Platform.h:155
> +#if defined(__arm64__) && defined(__APPLE__) || defined(__aarch64__)

I would put a bracket around the && part.
Comment 4 Gabor Rapcsanyi 2014-03-25 06:14:29 PDT 
Thanks for the review, I changed what Zoltan suggested.
Patch landed: 
http://trac.webkit.org/changeset/166232
Comment 5 Gyuyoung Kim 2014-03-25 22:45:40 PDT 
Thank you for great work for EFL port. BTW, I wonder whether EFL ARM bot compiles EFL port based on ARM64 architecture.
Comment 6 Gabor Rapcsanyi 2014-03-26 00:28:08 PDT 
(In reply to comment #5)
> Thank you for great work for EFL port. BTW, I wonder whether EFL ARM bot compiles EFL port based on ARM64 architecture.

Yes, the EFL port is now building for ARM64 and also we have an EFL ARM64 builder bot here: http://build.webkit.sed.hu/waterfall

We have some problems with the dependencies so they are built by hand now. If we can solve this in the future we can connect this bot to the Apple master.
Comment 7 Gyuyoung Kim 2014-03-26 00:29:34 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > Thank you for great work for EFL port. BTW, I wonder whether EFL ARM bot compiles EFL port based on ARM64 architecture.
> 
> Yes, the EFL port is now building for ARM64 and also we have an EFL ARM64 builder bot here: http://build.webkit.sed.hu/waterfall
> 
> We have some problems with the dependencies so they are built by hand now. If we can solve this in the future we can connect this bot to the Apple master.

Nice. I hope to see it on build.webkit.org in near future. Thanks a lot !