Bug 130041 - Repatch should save and restore all used registers - not just temp ones - when making a call
Summary: Repatch should save and restore all used registers - not just temp ones - whe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2014-03-10 14:30 PDT by Filip Pizlo
Modified: 2014-03-10 16:26 PDT (History)
10 users (show)

See Also:

Attachments
the patch (15.68 KB, patch)
2014-03-10 14:32 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-03-10 14:30:24 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-03-10 14:32:47 PDT 
Created attachment 226335 [details]
the patch
Comment 2 WebKit Commit Bot 2014-03-10 14:34:25 PDT 
Attachment 226335 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/ScratchRegisterAllocator.h:72:  The parameter name "scratchBuffer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/jit/ScratchRegisterAllocator.h:74:  The parameter name "scratchBuffer" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2014-03-10 14:37:43 PDT 
Comment on attachment 226335 [details]
the patch

r=me
Comment 4 Filip Pizlo 2014-03-10 16:26:13 PDT 
Landed in http://trac.webkit.org/changeset/165414