Bug 129998 - GPRInfo::toIndex should return InvalidIndex for non-temp registers on ARM64
Summary: GPRInfo::toIndex should return InvalidIndex for non-temp registers on ARM64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency treegraph
 
Reported: 2014-03-09 20:08 PDT by Filip Pizlo
Modified: 2014-03-09 23:51 PDT (History)
9 users (show)

See Also:


Attachments
the patch (1.83 KB, patch)
2014-03-09 20:12 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-03-09 20:08:47 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2014-03-09 20:12:06 PDT
Created attachment 226276 [details]
the patch

Still running tests to confirm that this is ok.
Comment 2 Mark Lam 2014-03-09 20:17:17 PDT
Comment on attachment 226276 [details]
the patch

Do we need to ASSERT(index <= regT15) in toRegister() to match this?
Comment 3 Filip Pizlo 2014-03-09 20:19:19 PDT
(In reply to comment #2)
> (From update of attachment 226276 [details])
> Do we need to ASSERT(index <= regT15) in toRegister() to match this?

I suppose we could add one.  I'm not sure how much good it would do, though.
Comment 4 Geoffrey Garen 2014-03-09 23:48:04 PDT
Comment on attachment 226276 [details]
the patch

r=me
Comment 5 Filip Pizlo 2014-03-09 23:51:34 PDT
Landed in http://trac.webkit.org/changeset/165362