Bug 129806 - Clarify how we deal with "special" registers
Summary: Clarify how we deal with "special" registers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 129822
Blocks: 112840
  Show dependency treegraph
 
Reported: 2014-03-06 09:46 PST by Filip Pizlo
Modified: 2014-03-07 14:17 PST (History)
10 users (show)

See Also:


Attachments
the patch (15.17 KB, patch)
2014-03-06 09:51 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (15.08 KB, patch)
2014-03-06 09:53 PST, Filip Pizlo
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-03-06 09:46:12 PST
What is "special" anyway?  Nobody knows!  This bug aims to fix that.
Comment 1 Filip Pizlo 2014-03-06 09:51:25 PST
Created attachment 226001 [details]
the patch
Comment 2 Filip Pizlo 2014-03-06 09:53:12 PST
Created attachment 226002 [details]
the patch
Comment 3 Michael Saboff 2014-03-06 09:58:23 PST
Comment on attachment 226002 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226002&action=review

r=me

> Source/JavaScriptCore/ChangeLog:16
> +        you also have to wrory about the LR register, which we'd want to say is "not real" but it's

*worry*
Comment 4 Filip Pizlo 2014-03-06 10:27:50 PST
Landed in http://trac.webkit.org/changeset/165196
Comment 5 WebKit Commit Bot 2014-03-06 13:13:58 PST
Re-opened since this is blocked by bug 129822
Comment 6 Michael Saboff 2014-03-07 14:17:05 PST
Committed r165293: <http://trac.webkit.org/changeset/165293>