Bug 129787 – AX: supportsARIAExpanded should always return true for a few roles: combobox, disclosure.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[James Craig]

AX: supportsARIAExpanded should always return true for a few roles: treeitem, combobox, disclosure. Currently it's:

bool AccessibilityObject::supportsARIAExpanded() const
{
    // Undefined values should not result in this attribute being exposed to ATs unless.
    const AtomicString& expanded = getAttribute(aria_expandedAttr);
    return equalIgnoringCase(expanded, "true") || equalIgnoringCase(expanded, "false");
}

To whoever fixes this, run the inspector-protocol layout tests in addition to the accessibility tests.

[Radar WebKit Bug Importer]

<rdar://problem/16334538>

[James Craig]

Removing TreeItemRole from this list, as not all tree items are expandable.

[James Craig]

Created attachment 228407 [details]
patch

[WebKit Commit Bot]

Attachment 228407 [details] did not pass style-queue:


ERROR: Source/WebCore/accessibility/AccessibilityObject.cpp:1966:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[James Craig]

I think I'm going to file a bug that prepare-changelog and svn-create-patch should automatically run check-webkit-style. I forget to do this probably half the time.

[James Craig]

Created attachment 228409 [details]
patch

[James Craig]

Bug 131115: prepare-changelog and svn-create-patch should automatically run check-webkit-style.

[chris fleizach]

Comment on attachment 228409 [details]
patch

do you need to rebaseline?

[James Craig]

Not that I know of. cq?

[WebKit Commit Bot]

Comment on attachment 228409 [details]
patch

Rejecting attachment 228409 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 228409, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
l/dom/getAccessibilityPropertiesForNode-expected.txt
Hunk #1 FAILED at 4.
1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt.rej
patching file LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html
Hunk #1 succeeded at 116 (offset -1 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Fleizach']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6382556920414208

[James Craig]

I guess so.

[James Craig]

Created attachment 228634 [details]
patch with baseline

[WebKit Commit Bot]

Comment on attachment 228634 [details]
patch with baseline

Clearing flags on attachment: 228634

Committed r166817: <http://trac.webkit.org/changeset/166817>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.