WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129755
More FTL ARM fixes
https://bugs.webkit.org/show_bug.cgi?id=129755
Summary
More FTL ARM fixes
Filip Pizlo
Reported
2014-03-05 13:31:26 PST
Patch forthcoming.
Attachments
the patch
(15.04 KB, patch)
2014-03-05 13:33 PST
,
Filip Pizlo
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2014-03-05 13:33:41 PST
Created
attachment 225908
[details]
the patch
WebKit Commit Bot
Comment 2
2014-03-05 13:36:23 PST
Attachment 225908
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLDataSection.h:39: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3
2014-03-05 13:40:47 PST
Comment on
attachment 225908
[details]
the patch View in context:
https://bugs.webkit.org/attachment.cgi?id=225908&action=review
r=me
> Source/JavaScriptCore/ChangeLog:11 > + - Temporarily switch to allocating all MCJIT memory in the executable pool on non-x86 > + platforms.
Can you file a bug about undoing this?
> Source/JavaScriptCore/ftl/FTLDataSection.h:39 > + DataSection(VM&, CodeBlock*, size_t size, unsigned alignment);
Nix "size", please.
Filip Pizlo
Comment 4
2014-03-05 13:46:38 PST
(In reply to
comment #3
)
> (From update of
attachment 225908
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=225908&action=review
> > r=me > > > Source/JavaScriptCore/ChangeLog:11 > > + - Temporarily switch to allocating all MCJIT memory in the executable pool on non-x86 > > + platforms. > > Can you file a bug about undoing this?
https://bugs.webkit.org/show_bug.cgi?id=129756
I added a fixme that references it also.
> > > Source/JavaScriptCore/ftl/FTLDataSection.h:39 > > + DataSection(VM&, CodeBlock*, size_t size, unsigned alignment); > > Nix "size", please.
Filip Pizlo
Comment 5
2014-03-05 13:56:41 PST
Landed in
http://trac.webkit.org/changeset/165129
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug