Bug 129747 - FTL loadStructure always generates invalid IR
Summary: FTL loadStructure always generates invalid IR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2014-03-05 10:59 PST by Filip Pizlo
Modified: 2014-03-05 12:21 PST (History)
9 users (show)

See Also:

Attachments
the patch (11.06 KB, patch)
2014-03-05 11:54 PST, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-03-05 10:59:47 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-03-05 11:54:36 PST 
Created attachment 225898 [details]
the patch
Comment 2 Mark Hahnenberg 2014-03-05 12:02:38 PST 
Comment on attachment 225898 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225898&action=review

r=me

> Source/JavaScriptCore/ftl/FTLOutput.h:210
> +    // are actuall integers. This requires an LLVM pointer. Broadly speaking, you don't

actually
Comment 3 Filip Pizlo 2014-03-05 12:21:58 PST 
Landed in http://trac.webkit.org/changeset/165119