RESOLVED FIXED Bug 129669
Move the rest of Source/WebCore/html/ code to std::unique_ptr 
https://bugs.webkit.org/show_bug.cgi?id=129669
Summary Move the rest of Source/WebCore/html/ code to std::unique_ptr
Zan Dobersek
Reported 2014-03-04 01:23:17 PST
Move the rest of Source/WebCore/html/ code to std::unique_ptr
Attachments
Patch (28.81 KB, patch)
2014-03-04 01:24 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (24.74 KB, patch)
2014-03-25 13:38 PDT, Zan Dobersek 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-03-04 01:24:02 PST
Created attachment 225753 [details] Patch
Zan Dobersek
Comment 2 2014-03-25 13:38:47 PDT
Created attachment 227789 [details] Patch
Anders Carlsson
Comment 3 2014-03-29 09:03:41 PDT
Comment on attachment 227789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227789&action=review > Source/WebCore/html/FormController.cpp:219 > + return std::move(savedFormState); Is move really needed here? > Source/WebCore/html/FormController.cpp:289 > + FormKeyGenerator() = default; Does this constructor even have to be defined? > Source/WebCore/html/FormController.cpp:399 > + auto keyGenerator = std::make_unique<FormKeyGenerator>(); Maybe FormKeyGenerator can just be allocated on the stack? > Source/WebCore/html/FormController.cpp:459 > + std::unique_ptr<SavedFormState> state = SavedFormState::deserialize(stateVector, i); auto.
Zan Dobersek
Comment 4 2014-03-31 03:46:53 PDT
Committed r166491: <http://trac.webkit.org/changeset/166491>
Note You need to log in before you can comment on or make changes to this bug.