Bug 129633 - Web Inspector: Better Debugger popovers for RegExp values
Summary: Web Inspector: Better Debugger popovers for RegExp values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-03 16:03 PST by Jonathan Wells
Modified: 2014-03-03 17:15 PST (History)
5 users (show)

See Also:

Attachments
[TEST] test case (435 bytes, text/html)
2014-03-03 16:03 PST, Jonathan Wells 		no flags Details
[PATCH] Proposed fix (2.19 KB, patch)
2014-03-03 16:10 PST, Jonathan Wells 		no flags Details | Formatted Diff | Diff
[SCREENSHOT] popover screenshot (31.22 KB, image/png)
2014-03-03 16:35 PST, Jonathan Wells 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Wells 2014-03-03 16:03:52 PST 
Created attachment 225705 [details]
[TEST] test case

* SUMMARY
Currently debugger popovers for RegExp values appear as full-fledged object graphs. It would be nice to display them more like a string. Compare to the JS Console.

* STEPS TO REPRODUCE
1. Open the attached test case.
2. Hover variable "regex" which holds a RegExp.
  => expected cleaner output like the console / hovering "string"
Comment 1 Radar WebKit Bug Importer 2014-03-03 16:04:29 PST 
<rdar://problem/16216851>
Comment 2 Timothy Hatcher 2014-03-03 16:06:58 PST 
<rdar://problem/13200695>
Comment 3 Jonathan Wells 2014-03-03 16:10:12 PST 
Created attachment 225707 [details]
[PATCH] Proposed fix
Comment 4 Timothy Hatcher 2014-03-03 16:15:44 PST 
Comment on attachment 225707 [details]
[PATCH] Proposed fix

Can you attach a screenshot?
Comment 5 Jonathan Wells 2014-03-03 16:35:44 PST 
Created attachment 225710 [details]
[SCREENSHOT] popover screenshot
Comment 6 Timothy Hatcher 2014-03-03 16:44:05 PST 
Comment on attachment 225707 [details]
[PATCH] Proposed fix

Looks good. We should probably update the color console-formatted-regexp uses to match the orange CodeMirror uses.
Comment 7 Joseph Pecoraro 2014-03-03 16:54:03 PST 
(In reply to comment #6)
> (From update of attachment 225707 [details])
> Looks good. We should probably update the color console-formatted-regexp uses to match the orange CodeMirror uses.

Yeah, I would like that.
Comment 8 Jonathan Wells 2014-03-03 17:13:27 PST 
https://bugs.webkit.org/show_bug.cgi?id=129645
Comment 9 WebKit Commit Bot 2014-03-03 17:15:21 PST 
Comment on attachment 225707 [details]
[PATCH] Proposed fix

Clearing flags on attachment: 225707

Committed r165026: <http://trac.webkit.org/changeset/165026>
Comment 10 WebKit Commit Bot 2014-03-03 17:15:24 PST 
All reviewed patches have been landed.  Closing bug.