Bug 129645 - Web Inspector: Match color of regex in source view with a popover
Summary: Web Inspector: Match color of regex in source view with a popover
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-03 17:10 PST by Jonathan Wells
Modified: 2014-03-03 22:47 PST (History)
5 users (show)

See Also:

Attachments
[TEST] popover test case (435 bytes, text/html)
2014-03-03 17:10 PST, Jonathan Wells 		no flags Details
[SCREENSHOT] before patch (31.22 KB, image/png)
2014-03-03 17:11 PST, Jonathan Wells 		no flags Details
[PATCH] Proposed fix (1.36 KB, patch)
2014-03-03 20:35 PST, Jonathan Wells 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Wells 2014-03-03 17:10:37 PST 
Created attachment 225717 [details]
[TEST] popover test case

The color for a regular expression in a source popover should be the same orange color that codemirror uses in the source view.

* STEPS TO REPRODUCE
1. Open the attached test case
2. Hover variable "regex" which holds a RegExp.
  => expected color of regexp to be the same orange color as it appears in the source in the assignment on line 7.
Comment 1 Radar WebKit Bug Importer 2014-03-03 17:11:11 PST 
<rdar://problem/16217977>
Comment 2 Jonathan Wells 2014-03-03 17:11:26 PST 
Created attachment 225718 [details]
[SCREENSHOT] before patch
Comment 3 Jonathan Wells 2014-03-03 20:35:25 PST 
Created attachment 225735 [details]
[PATCH] Proposed fix
Comment 4 WebKit Commit Bot 2014-03-03 22:47:17 PST 
Comment on attachment 225735 [details]
[PATCH] Proposed fix

Clearing flags on attachment: 225735

Committed r165039: <http://trac.webkit.org/changeset/165039>
Comment 5 WebKit Commit Bot 2014-03-03 22:47:19 PST 
All reviewed patches have been landed.  Closing bug.