Bug 129159 - Revive SABI (aka shouldAlwaysBeInlined)
Summary: Revive SABI (aka shouldAlwaysBeInlined)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2014-02-21 11:39 PST by Filip Pizlo
Modified: 2014-02-21 11:43 PST (History)
9 users (show)

See Also:

Attachments
the patch (1.57 KB, patch)
2014-02-21 11:40 PST, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-21 11:39:09 PST 
JSC has some cleverness for rapidly identifying functions that will always be inlined and so do not need to be separately optimized.  We broke this when we got rid of the baseline JIT inline caches and replaced them with the DFG ones.
Comment 1 Filip Pizlo 2014-02-21 11:40:57 PST 
Created attachment 224886 [details]
the patch
Comment 2 Mark Hahnenberg 2014-02-21 11:42:04 PST 
Comment on attachment 224886 [details]
the patch

r=me
Comment 3 Filip Pizlo 2014-02-21 11:43:17 PST 
Landed in http://trac.webkit.org/changeset/164490