WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129078
Start to use std::unique_ptr for DragImageLoader
https://bugs.webkit.org/show_bug.cgi?id=129078
Summary
Start to use std::unique_ptr for DragImageLoader
Gyuyoung Kim
Reported
2014-02-19 18:15:17 PST
As a step to use std::unique_ptr, this patch replace uses of OwnPtr and PassOwnPtr in the DragImageLoader class with std::unique_ptr.
Attachments
Patch
(2.81 KB, patch)
2014-02-19 18:16 PST
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Patch for landing
(2.88 KB, patch)
2014-02-20 18:09 PST
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Patch for landing
(2.94 KB, patch)
2014-02-20 18:12 PST
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1
2014-02-19 18:16:16 PST
Created
attachment 224699
[details]
Patch
Alex Christensen
Comment 2
2014-02-20 16:37:42 PST
looks good to me, but I'm not a reviewer yet :(
Ryosuke Niwa
Comment 3
2014-02-20 16:45:57 PST
Comment on
attachment 224699
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=224699&action=review
> Source/WebCore/dom/Clipboard.cpp:45 > WTF_MAKE_FAST_ALLOCATED;
We should probably make this class non-copyable as well...
Gyuyoung Kim
Comment 4
2014-02-20 18:09:52 PST
Created
attachment 224816
[details]
Patch for landing
Gyuyoung Kim
Comment 5
2014-02-20 18:12:57 PST
Created
attachment 224817
[details]
Patch for landing
Gyuyoung Kim
Comment 6
2014-02-20 19:59:39 PST
Committed
r164465
: <
http://trac.webkit.org/changeset/164465
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug