Bug 129078 - Start to use std::unique_ptr for DragImageLoader
Summary: Start to use std::unique_ptr for DragImageLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 128007
  Show dependency tree / graph
 
Reported: 2014-02-19 18:15 PST by Gyuyoung Kim
Modified: 2014-02-20 19:59 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.81 KB, patch)
2014-02-19 18:16 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (2.88 KB, patch)
2014-02-20 18:09 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (2.94 KB, patch)
2014-02-20 18:12 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-02-19 18:15:17 PST 
As a step to use std::unique_ptr, this patch replace uses of OwnPtr and PassOwnPtr in the DragImageLoader class with std::unique_ptr.
Comment 1 Gyuyoung Kim 2014-02-19 18:16:16 PST 
Created attachment 224699 [details]
Patch
Comment 2 Alex Christensen 2014-02-20 16:37:42 PST 
looks good to me, but I'm not a reviewer yet :(
Comment 3 Ryosuke Niwa 2014-02-20 16:45:57 PST 
Comment on attachment 224699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224699&action=review

> Source/WebCore/dom/Clipboard.cpp:45
>      WTF_MAKE_FAST_ALLOCATED;

We should probably make this class non-copyable as well...
Comment 4 Gyuyoung Kim 2014-02-20 18:09:52 PST 
Created attachment 224816 [details]
Patch for landing
Comment 5 Gyuyoung Kim 2014-02-20 18:12:57 PST 
Created attachment 224817 [details]
Patch for landing
Comment 6 Gyuyoung Kim 2014-02-20 19:59:39 PST 
Committed r164465: <http://trac.webkit.org/changeset/164465>