Bug 129023 - Correctly install libllvmForJSC.dylib in production builds
Summary: Correctly install libllvmForJSC.dylib in production builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency treegraph
 
Reported: 2014-02-18 20:45 PST by Filip Pizlo
Modified: 2014-02-18 21:41 PST (History)
10 users (show)

See Also:


Attachments
the patch (2.79 KB, patch)
2014-02-18 20:46 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (2.77 KB, patch)
2014-02-18 20:51 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (4.16 KB, patch)
2014-02-18 21:03 PST, Filip Pizlo
mrowe: review-
Details | Formatted Diff | Diff
the patch (4.63 KB, patch)
2014-02-18 21:29 PST, Filip Pizlo
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-18 20:45:21 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2014-02-18 20:46:18 PST
Created attachment 224583 [details]
the patch
Comment 2 Filip Pizlo 2014-02-18 20:51:04 PST
Created attachment 224584 [details]
the patch

Fix install path.
Comment 3 Filip Pizlo 2014-02-18 21:03:40 PST
Created attachment 224585 [details]
the patch
Comment 4 Mark Rowe (bdash) 2014-02-18 21:15:36 PST
Comment on attachment 224585 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224585&action=review

> Source/JavaScriptCore/Configurations/Base.xcconfig:111
> +JAVASCRIPTCORE_LIBRARIES_DIR_macosx = JavaScriptCore.framework/Versions/A/Resources;

This isn't the right path.

I'd suggest pulling out a JAVASCRIPTCORE_CONTENTS_DIR variable that's JavaScriptCore.framework on iOS and JavaScriptCore.framework/Versions/A on OS X, then just defining JAVASCRIPTCORE_RESOURCES_DIR = $(JAVASCRIPTCORE_CONTENTS_DIR)/Resources and JAVASCRIPTCORE_LIBRARIES_DIR = $(JAVASCRIPTCORE_CONTENTS_DIR)/Libraries/. We don't need to repeat the conditionals twice.
Comment 5 Filip Pizlo 2014-02-18 21:29:38 PST
Created attachment 224589 [details]
the patch
Comment 6 Filip Pizlo 2014-02-18 21:41:35 PST
Landed in http://trac.webkit.org/changeset/164354