Bug 129018 - The shell scripts in the Xcode build system should tell you when they failed
Summary: The shell scripts in the Xcode build system should tell you when they failed
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Blocks: 129019 112840
  Show dependency treegraph
Reported: 2014-02-18 19:40 PST by Filip Pizlo
Modified: 2014-02-18 20:03 PST (History)
10 users (show)

See Also:

the patch (3.28 KB, patch)
2014-02-18 19:41 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (8.13 KB, patch)
2014-02-18 19:54 PST, Filip Pizlo
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-18 19:40:37 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2014-02-18 19:41:34 PST
Created attachment 224577 [details]
the patch
Comment 2 Mark Rowe (bdash) 2014-02-18 19:44:50 PST
Comment on attachment 224577 [details]
the patch

These could a single invocation as "set -ex", but I'm not sure why you're doing "set -x" in the first place. That's going to make things awfully verbose.

It's also not clear why you're only updating these two phases rather than all of the script phases in JavaScriptCore.xcodeproj (and the remainder of WebKit).
Comment 3 Filip Pizlo 2014-02-18 19:54:26 PST
Created attachment 224578 [details]
the patch

Using set -e only now, and using it in all JSC script phases.
Comment 4 Filip Pizlo 2014-02-18 20:03:51 PST
Landed in http://trac.webkit.org/changeset/164348