Bug 128967 - Move to using std::unique_ptr for VisitedLinkState, CheckedRadioButtons
Summary: Move to using std::unique_ptr for VisitedLinkState, CheckedRadioButtons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 128007
  Show dependency tree / graph
 
Reported: 2014-02-18 04:21 PST by Zan Dobersek
Modified: 2014-02-20 04:24 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.37 KB, patch)
2014-02-19 13:48 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (7.38 KB, patch)
2014-02-19 14:02 PST, Zan Dobersek 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-02-18 04:21:11 PST 
Move to using std::unique_ptr for VisitedLinkState
Comment 1 Zan Dobersek 2014-02-19 13:48:20 PST 
Created attachment 224669 [details]
Patch
Comment 2 Zan Dobersek 2014-02-19 14:02:49 PST 
Created attachment 224673 [details]
Patch
Comment 3 Andreas Kling 2014-02-19 16:10:09 PST 
Comment on attachment 224673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224673&action=review

r=me

> Source/WebCore/dom/CheckedRadioButtons.cpp:189
> +    std::unique_ptr<RadioButtonGroup>& group = m_nameToGroupMap->add(element->name().impl(), nullptr).iterator->value;

I'd use "auto&" here.
Comment 4 Zan Dobersek 2014-02-20 04:24:43 PST 
Committed r164425: <http://trac.webkit.org/changeset/164425>