WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128964
Move IndexedDB module, LevelDB code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=128964
Summary
Move IndexedDB module, LevelDB code to std::unique_ptr
Zan Dobersek
Reported
2014-02-18 02:38:03 PST
Move IndexedDB module, LevelDB code to std::unique_ptr
Attachments
Patch
(45.29 KB, patch)
2014-02-18 02:39 PST
,
Zan Dobersek
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2014-02-18 02:39:11 PST
Created
attachment 224488
[details]
Patch
Andreas Kling
Comment 2
2014-02-18 10:32:34 PST
Comment on
attachment 224488
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=224488&action=review
r=me
> Source/WebCore/Modules/indexeddb/IDBPendingDeleteCall.h:38 > + IDBPendingDeleteCall(PassRefPtr<IDBCallbacks> callbacks)
explicit
> Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:266 > + IteratorImpl(std::unique_ptr<leveldb::Iterator>);
explicit
> Source/WebCore/platform/leveldb/LevelDBTransaction.h:102 > + TreeIterator(LevelDBTransaction*);
explicit
> Source/WebCore/platform/leveldb/LevelDBTransaction.h:124 > + TransactionIterator(PassRefPtr<LevelDBTransaction>);
explicit
> Source/WebCore/platform/leveldb/LevelDBTransaction.h:174 > + LevelDBWriteOnlyTransaction(LevelDBDatabase*);
explicit
Zan Dobersek
Comment 3
2014-02-18 14:03:43 PST
Committed
r164314
: <
http://trac.webkit.org/changeset/164314
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug