RESOLVED FIXED 128530
Enable CSS_SHAPE_INSIDE in CMake files 
https://bugs.webkit.org/show_bug.cgi?id=128530
Summary Enable CSS_SHAPE_INSIDE in CMake files
Krzysztof Wolanski
Reported 2014-02-10 06:27:49 PST
CSS_SHAPE_INSIDE flag was added in r163333, this patch is turning on this flag in CMake files.
Attachments
proposed patch (1.94 KB, patch)
2014-02-10 06:29 PST, Krzysztof Wolanski 		gyuyoung.kim: review+
DetailsFormatted DiffDiff
apply suggestions (1.95 KB, patch)
2014-02-10 07:06 PST, Krzysztof Wolanski 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
apply suggestions (1.95 KB, patch)
2014-02-10 07:18 PST, Krzysztof Wolanski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Krzysztof Wolanski
Comment 1 2014-02-10 06:29:33 PST
Created attachment 223703 [details] proposed patch
Gyuyoung Kim
Comment 2 2014-02-10 06:57:32 PST
Comment on attachment 223703 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=223703&action=review Please land this after modifying description of changelog. > ChangeLog:3 > + Enable CSS_SHAPE_INSIDE in CMake files Current patch is just to add the CSS_SHAPE_INSIDE to CMake feature list. > ChangeLog:9 > + this patch is turning on this flag in CMake files. ditto.
Csaba Osztrogonác
Comment 3 2014-02-10 07:00:25 PST
*** Bug 128525 has been marked as a duplicate of this bug. ***
Krzysztof Wolanski
Comment 4 2014-02-10 07:06:13 PST
Created attachment 223705 [details] apply suggestions
WebKit Commit Bot
Comment 5 2014-02-10 07:09:41 PST
Comment on attachment 223705 [details] apply suggestions Rejecting attachment 223705 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 223705, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6623476500660224
Gyuyoung Kim
Comment 6 2014-02-10 07:13:09 PST
Krzysztof, if you get r+, you need to fill "Reviewed by XXX" in ChangeLog. If you use Tools/Script/webkit-patch apply-attachment apply-attachment *attachment number*, the webkit-patch will fill it automatically.
Krzysztof Wolanski
Comment 7 2014-02-10 07:18:57 PST
Created attachment 223707 [details] apply suggestions
Gyuyoung Kim
Comment 8 2014-02-10 07:23:05 PST
(In reply to comment #3) > *** Bug 128525 has been marked as a duplicate of this bug. *** Sorry for missing it before taking a look this one.
WebKit Commit Bot
Comment 9 2014-02-10 07:57:19 PST
Comment on attachment 223707 [details] apply suggestions Clearing flags on attachment: 223707 Committed r163786: <http://trac.webkit.org/changeset/163786>
WebKit Commit Bot
Comment 10 2014-02-10 07:57:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.