Bug 128530 - Enable CSS_SHAPE_INSIDE in CMake files
Summary: Enable CSS_SHAPE_INSIDE in CMake files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 128525 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-02-10 06:27 PST by Krzysztof Wolanski
Modified: 2014-02-10 07:57 PST (History)
7 users (show)

See Also:

Attachments
proposed patch (1.94 KB, patch)
2014-02-10 06:29 PST, Krzysztof Wolanski 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
apply suggestions (1.95 KB, patch)
2014-02-10 07:06 PST, Krzysztof Wolanski 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
apply suggestions (1.95 KB, patch)
2014-02-10 07:18 PST, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Wolanski 2014-02-10 06:27:49 PST 
CSS_SHAPE_INSIDE flag was added in r163333, this patch is turning on this flag in CMake files.
Comment 1 Krzysztof Wolanski 2014-02-10 06:29:33 PST 
Created attachment 223703 [details]
proposed patch
Comment 2 Gyuyoung Kim 2014-02-10 06:57:32 PST 
Comment on attachment 223703 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223703&action=review

Please land this after modifying description of changelog.

> ChangeLog:3
> +        Enable CSS_SHAPE_INSIDE in CMake files

Current patch is just to add the CSS_SHAPE_INSIDE to CMake feature list.

> ChangeLog:9
> +        this patch is turning on this flag in CMake files.

ditto.
Comment 3 Csaba Osztrogonác 2014-02-10 07:00:25 PST 
*** Bug 128525 has been marked as a duplicate of this bug. ***
Comment 4 Krzysztof Wolanski 2014-02-10 07:06:13 PST 
Created attachment 223705 [details]
apply suggestions
Comment 5 WebKit Commit Bot 2014-02-10 07:09:41 PST 
Comment on attachment 223705 [details]
apply suggestions

Rejecting attachment 223705 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 223705, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6623476500660224
Comment 6 Gyuyoung Kim 2014-02-10 07:13:09 PST 
Krzysztof, if you get r+, you need to fill "Reviewed by XXX" in ChangeLog. If you use Tools/Script/webkit-patch apply-attachment apply-attachment *attachment number*, the webkit-patch will fill it automatically.
Comment 7 Krzysztof Wolanski 2014-02-10 07:18:57 PST 
Created attachment 223707 [details]
apply suggestions
Comment 8 Gyuyoung Kim 2014-02-10 07:23:05 PST 
(In reply to comment #3)
> *** Bug 128525 has been marked as a duplicate of this bug. ***

Sorry for missing it before taking a look this one.
Comment 9 WebKit Commit Bot 2014-02-10 07:57:19 PST 
Comment on attachment 223707 [details]
apply suggestions

Clearing flags on attachment: 223707

Committed r163786: <http://trac.webkit.org/changeset/163786>
Comment 10 WebKit Commit Bot 2014-02-10 07:57:23 PST 
All reviewed patches have been landed.  Closing bug.