Bug 128525 - [cmake] Feature flag for shape-inside
Summary: [cmake] Feature flag for shape-inside
Status: RESOLVED DUPLICATE of bug 128530
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 128001
  Show dependency tree / graph
 
Reported: 2014-02-10 04:14 PST by Csaba Osztrogonác
Modified: 2014-02-13 03:54 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2014-02-10 04:17 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-02-10 04:14:58 PST 
https://trac.webkit.org/changeset/163333 added CSS_SHAPE_INSIDE guards and enabled it on Mac. 
But this change didn't add this new guard to cmake build system which disabled it automatically 
and made ~100 tests fail.

We should add it to cmake to enable it automatically and make tests pass again. Patch is coming soon.
Comment 1 Csaba Osztrogonác 2014-02-10 04:17:17 PST 
Created attachment 223694 [details]
Patch

tested locally, fast/shapes/shape-inside/* tests pass again with it
Comment 2 Csaba Osztrogonác 2014-02-10 04:29:59 PST 
Otherwise it is a little bit strange for me that there are many default
OFF features in Source/cmake/WebKitFeatures.cmake which are always
overridden by build-webkit ... (defaults in FeatureList.pm)

Shouldn't we unify the two file somehow?
Comment 3 Csaba Osztrogonác 2014-02-10 04:32:09 PST 
not to mention OptionsEfl.cmake ...
Comment 4 Csaba Osztrogonác 2014-02-10 07:00:25 PST 

*** This bug has been marked as a duplicate of bug 128530 ***
Comment 5 Dean Jackson 2014-02-11 10:15:30 PST 
Sorry :(
Comment 6 Csaba Osztrogonác 2014-02-13 03:54:36 PST 
Comment on attachment 223694 [details]
Patch

Cleared review? from attachment 223694 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).