Bug 128496 - [GTK] Fix modifiers on EventSenderProxy::keyDown
Summary: [GTK] Fix modifiers on EventSenderProxy::keyDown
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-09 02:21 PST by Carlos Garnacho
Modified: 2014-02-09 03:34 PST (History)
2 users (show)

See Also:

Attachments
patch, fixes modifiers on keyDown (1.45 KB, patch)
2014-02-09 02:23 PST, Carlos Garnacho 		cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff
patch, fix indentation issues (1.47 KB, patch)
2014-02-09 02:36 PST, Carlos Garnacho 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garnacho 2014-02-09 02:21:07 PST 
On my patch in bug #128171, I went far too eagerly to check direct usages of wkModifiers, failing to realize that keyDown() was already transforming that to a GTK+ modifier mask at the beginning of the function, I'm attaching a patch that fixes it back, sorry about that...
Comment 1 Carlos Garnacho 2014-02-09 02:23:07 PST 
Created attachment 223621 [details]
patch, fixes modifiers on keyDown
Comment 2 WebKit Commit Bot 2014-02-09 02:25:25 PST 
Attachment 223621 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:3:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2014-02-09 02:26:00 PST 
Comment on attachment 223621 [details]
patch, fixes modifiers on keyDown

Oops
Comment 4 Carlos Garcia Campos 2014-02-09 02:26:29 PST 
Comment on attachment 223621 [details]
patch, fixes modifiers on keyDown

Oh, please fix the changelog.
Comment 5 Carlos Garnacho 2014-02-09 02:36:00 PST 
Created attachment 223622 [details]
patch, fix indentation issues
Comment 6 WebKit Commit Bot 2014-02-09 03:34:32 PST 
Comment on attachment 223622 [details]
patch, fix indentation issues

Clearing flags on attachment: 223622

Committed r163750: <http://trac.webkit.org/changeset/163750>
Comment 7 WebKit Commit Bot 2014-02-09 03:34:34 PST 
All reviewed patches have been landed.  Closing bug.