Bug 128171 - [GTK] Ensure EventSenderProxyGtk generates GdkEvents with a GdkModifierType
Summary: [GTK] Ensure EventSenderProxyGtk generates GdkEvents with a GdkModifierType
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 98931
  Show dependency tree / graph
 
Reported: 2014-02-04 03:07 PST by Carlos Garnacho
Modified: 2014-02-04 04:37 PST (History)
1 user (show)

See Also:

Attachments
Patch. translates modifiers to GDK ones where missing (3.89 KB, patch)
2014-02-04 03:16 PST, Carlos Garnacho 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garnacho 2014-02-04 03:07:01 PST 
On some functions in EventSenderProxyGtk, the wkEventModifiers is being passed to the GdkEventState, event though the masks aren't compatible, on other functions this is done right though, so I'm adding a patch that shuffles the function so it's used all around.

This makes LayoutTests/fast/events/touch/emulate-touch-events.html fail if the patch in bug #98931 is applied.
Comment 1 Carlos Garnacho 2014-02-04 03:16:50 PST 
Created attachment 223092 [details]
Patch. translates modifiers to GDK ones where missing
Comment 2 Carlos Garcia Campos 2014-02-04 04:07:57 PST 
Comment on attachment 223092 [details]
Patch. translates modifiers to GDK ones where missing

LGTM, thanks.
Comment 3 WebKit Commit Bot 2014-02-04 04:37:52 PST 
Comment on attachment 223092 [details]
Patch. translates modifiers to GDK ones where missing

Clearing flags on attachment: 223092

Committed r163373: <http://trac.webkit.org/changeset/163373>
Comment 4 WebKit Commit Bot 2014-02-04 04:37:53 PST 
All reviewed patches have been landed.  Closing bug.