RESOLVED FIXED 128171
[GTK] Ensure EventSenderProxyGtk generates GdkEvents with a GdkModifierType 
https://bugs.webkit.org/show_bug.cgi?id=128171
Summary [GTK] Ensure EventSenderProxyGtk generates GdkEvents with a GdkModifierType
Carlos Garnacho
Reported 2014-02-04 03:07:01 PST
On some functions in EventSenderProxyGtk, the wkEventModifiers is being passed to the GdkEventState, event though the masks aren't compatible, on other functions this is done right though, so I'm adding a patch that shuffles the function so it's used all around. This makes LayoutTests/fast/events/touch/emulate-touch-events.html fail if the patch in bug #98931 is applied.
Attachments
Patch. translates modifiers to GDK ones where missing (3.89 KB, patch)
2014-02-04 03:16 PST, Carlos Garnacho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garnacho
Comment 1 2014-02-04 03:16:50 PST
Created attachment 223092 [details] Patch. translates modifiers to GDK ones where missing
Carlos Garcia Campos
Comment 2 2014-02-04 04:07:57 PST
Comment on attachment 223092 [details] Patch. translates modifiers to GDK ones where missing LGTM, thanks.
WebKit Commit Bot
Comment 3 2014-02-04 04:37:52 PST
Comment on attachment 223092 [details] Patch. translates modifiers to GDK ones where missing Clearing flags on attachment: 223092 Committed r163373: <http://trac.webkit.org/changeset/163373>
WebKit Commit Bot
Comment 4 2014-02-04 04:37:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.