RESOLVED FIXED 128471
Switch the rest of CSS code from OwnPtr over to std::unique_ptr 
https://bugs.webkit.org/show_bug.cgi?id=128471
Summary Switch the rest of CSS code from OwnPtr over to std::unique_ptr
Zan Dobersek
Reported 2014-02-08 13:38:17 PST
Switch the rest of CSS code from OwnPtr over to std::unique_ptr
Attachments
Patch (44.83 KB, patch)
2014-02-08 13:48 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-02-08 13:48:07 PST
Created attachment 223583 [details] Patch
WebKit Commit Bot
Comment 2 2014-02-08 13:50:08 PST
Attachment 223583 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSParser.cpp:11607: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] ERROR: Source/WebCore/css/CSSParser.cpp:11639: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2014-02-08 17:43:53 PST
Comment on attachment 223583 [details] Patch r=me
Zan Dobersek
Comment 4 2014-02-09 00:53:58 PST
Comment on attachment 223583 [details] Patch Clearing flags on attachment: 223583 Committed r163747: <http://trac.webkit.org/changeset/163747>
Zan Dobersek
Comment 5 2014-02-09 00:54:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.