Bug 128471 - Switch the rest of CSS code from OwnPtr over to std::unique_ptr
Summary: Switch the rest of CSS code from OwnPtr over to std::unique_ptr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 128007
  Show dependency tree / graph
 
Reported: 2014-02-08 13:38 PST by Zan Dobersek
Modified: 2014-02-09 00:54 PST (History)
7 users (show)

See Also:

Attachments
Patch (44.83 KB, patch)
2014-02-08 13:48 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-02-08 13:38:17 PST 
Switch the rest of CSS code from OwnPtr over to std::unique_ptr
Comment 1 Zan Dobersek 2014-02-08 13:48:07 PST 
Created attachment 223583 [details]
Patch
Comment 2 WebKit Commit Bot 2014-02-08 13:50:08 PST 
Attachment 223583 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSParser.cpp:11607:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
ERROR: Source/WebCore/css/CSSParser.cpp:11639:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-02-08 17:43:53 PST 
Comment on attachment 223583 [details]
Patch

r=me
Comment 4 Zan Dobersek 2014-02-09 00:53:58 PST 
Comment on attachment 223583 [details]
Patch

Clearing flags on attachment: 223583

Committed r163747: <http://trac.webkit.org/changeset/163747>
Comment 5 Zan Dobersek 2014-02-09 00:54:04 PST 
All reviewed patches have been landed.  Closing bug.