Bug 128436 - Web Inspector: DataGrid header should be position:sticky instead of a separate table
Summary: Web Inspector: DataGrid header should be position:sticky instead of a separat...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 128486
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-07 19:39 PST by BJ Burg
Modified: 2019-09-13 11:30 PDT (History)
3 users (show)

See Also:

Attachments
patch (21.96 KB, patch)
2014-02-08 21:03 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch (22.13 KB, patch)
2014-07-31 13:19 PDT, Brian Burg 		timothy: review+
burg: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-02-07 19:39:15 PST 
This also means the table need not be fixed-layout. Whether this simplifies widths assignment remains to be seen.
Comment 1 Radar WebKit Bug Importer 2014-02-07 19:39:48 PST 
<rdar://problem/16018605>
Comment 2 BJ Burg 2014-02-08 21:03:05 PST 
Created attachment 223606 [details]
patch
Comment 3 BJ Burg 2014-02-08 21:06:05 PST 
It works, but is an effective style regression due to rendering bugs. Wait before landing.
Comment 4 Timothy Hatcher 2014-02-09 13:14:25 PST 
Sweet! What style regressions? I know there are a few other stylesheets that might use "table.data" in the selector — namely TimelineDataGrid.css. Should be easy to grep for.
Comment 5 BJ Burg 2014-02-10 10:00:08 PST 
Regression is being worked on here: https://bugs.webkit.org/show_bug.cgi?id=128486 Looks related to subpixel or position:sticky + tables.
Comment 6 Brian Burg 2014-07-31 13:19:51 PDT 
Created attachment 235838 [details]
Patch

Rebased onto new directory structure. The visual glitches from before seem to be gone.
Comment 7 Timothy Hatcher 2014-07-31 13:30:05 PDT 
Comment on attachment 235838 [details]
Patch

I do have concerns this might break selectors that style DataGrid. Does Timeline look as expected? Any other DataGrids? At least we had API for scrollContainer.
Comment 8 Brian Burg 2014-07-31 17:31:24 PDT 
Comment on attachment 235838 [details]
Patch

I will double-check for style regressions tomorrow when I am physically sitting at the computer where I rebased this. I was mainly checking for the subpixel bug.
Comment 9 Joseph Pecoraro 2019-09-13 11:30:40 PDT 
This never landed. Should we close out the bug?