Bug 128298 - [EFL][WK2] Remove legacy behavior mode in MiniBrowser
Summary: [EFL][WK2] Remove legacy behavior mode in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-05 22:28 PST by Jinwoo Song
Modified: 2014-02-06 04:32 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.15 KB, patch)
2014-02-05 22:31 PST, Jinwoo Song
no flags Details | Formatted Diff | Diff
Patch (3.37 KB, patch)
2014-02-05 22:33 PST, Jinwoo Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-02-05 22:28:33 PST
MiniBrowser is crashing when the legacy mode is set in creating webview.
As EFL application cannot use this API for creating webview after r146265,
it would be better to remove this invalid option.
Comment 1 Jinwoo Song 2014-02-05 22:31:39 PST
Created attachment 223310 [details]
Patch
Comment 2 Jinwoo Song 2014-02-05 22:33:18 PST
Created attachment 223311 [details]
Patch
Comment 3 Gyuyoung Kim 2014-02-05 22:44:41 PST
Comment on attachment 223311 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-02-05 23:19:37 PST
Comment on attachment 223311 [details]
Patch

Clearing flags on attachment: 223311

Committed r163518: <http://trac.webkit.org/changeset/163518>
Comment 5 WebKit Commit Bot 2014-02-05 23:19:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryuan Choi 2014-02-05 23:31:18 PST
(In reply to comment #0)
> MiniBrowser is crashing when the legacy mode is set in creating webview.
> As EFL application cannot use this API for creating webview after r146265,
> it would be better to remove this invalid option.

I don't have objection about this because it was not maintained very long time.

But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2.

Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :(
Comment 7 Jinwoo Song 2014-02-05 23:38:34 PST
(In reply to comment #6)
> (In reply to comment #0)
> > MiniBrowser is crashing when the legacy mode is set in creating webview.
> > As EFL application cannot use this API for creating webview after r146265,
> > it would be better to remove this invalid option.
> 
> I don't have objection about this because it was not maintained very long time.
> 
> But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2.
> 
> Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :(

I definitely agree to you, so I have a plan to make a API to set fixedLayout and let application to configure it.
Comment 8 Jinwoo Song 2014-02-06 04:32:15 PST
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #0)
> > > MiniBrowser is crashing when the legacy mode is set in creating webview.
> > > As EFL application cannot use this API for creating webview after r146265,
> > > it would be better to remove this invalid option.
> > 
> > I don't have objection about this because it was not maintained very long time.
> > 
> > But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2.
> > 
> > Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :(
> 
> I definitely agree to you, so I have a plan to make a API to set fixedLayout and let application to configure it.

I filed a bug and upload a patch in bug 128300.