Bug 128300 - [EFL][WK2] WebView should be able to configure to set fixed layout
Summary: [EFL][WK2] WebView should be able to configure to set fixed layout
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
Depends on:
Reported: 2014-02-06 02:33 PST by Jinwoo Song
Modified: 2014-02-07 00:27 PST (History)
9 users (show)

See Also:

Patch (7.42 KB, patch)
2014-02-06 04:08 PST, Jinwoo Song
no flags Details | Formatted Diff | Diff
Patch (7.32 KB, patch)
2014-02-06 22:54 PST, Jinwoo Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-02-06 02:33:01 PST
Currently, webview is created by setting fixed layout as true and there is no way to change the setting.
But some applications may do not want to use fixed layout so I'd like to add ewk APIs to configure to it.
Comment 1 Jinwoo Song 2014-02-06 04:08:58 PST
Created attachment 223325 [details]
Comment 2 Ryuan Choi 2014-02-06 05:47:11 PST
Looks good to me.
Comment 3 Gyuyoung Kim 2014-02-06 17:21:12 PST
Comment on attachment 223325 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=223325&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:912
> + * *

Remove *.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:918
> +EAPI Eina_Bool ewk_view_use_fixed_layout_set(Evas_Object *o, Eina_Bool enabled);

Hmm, is *ewk_view_fixed_layout_set* enough ?

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:928
> +EAPI Eina_Bool ewk_view_use_fixed_layout_get(const Evas_Object *o);

Comment 4 Daniel Juyung Seo 2014-02-06 19:45:56 PST
How about ewk_view_layout_fixed_get/get()?
Comment 5 Gyuyoung Kim 2014-02-06 20:16:32 PST
(In reply to comment #4)
> How about ewk_view_layout_fixed_get/get()?

If it is more close to efl function naming style, I agree to use it !
Comment 6 Jinwoo Song 2014-02-06 22:54:05 PST
Created attachment 223426 [details]

Changed API name as suggested by Daniel and Gyuyoung.
Comment 7 Gyuyoung Kim 2014-02-06 23:50:22 PST
Comment on attachment 223426 [details]

Comment 8 WebKit Commit Bot 2014-02-07 00:27:37 PST
Comment on attachment 223426 [details]

Clearing flags on attachment: 223426

Committed r163614: <http://trac.webkit.org/changeset/163614>
Comment 9 WebKit Commit Bot 2014-02-07 00:27:40 PST
All reviewed patches have been landed.  Closing bug.