Bug 128300 – [EFL][WK2] WebView should be able to configure to set fixed layout

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jinwoo Song]

Currently, webview is created by setting fixed layout as true and there is no way to change the setting.
But some applications may do not want to use fixed layout so I'd like to add ewk APIs to configure to it.

[Jinwoo Song]

Created attachment 223325 [details]
Patch

[Ryuan Choi]

Looks good to me.

[Gyuyoung Kim]

Comment on attachment 223325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223325&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:912
> + * *

Remove *.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:918
> +EAPI Eina_Bool ewk_view_use_fixed_layout_set(Evas_Object *o, Eina_Bool enabled);

Hmm, is *ewk_view_fixed_layout_set* enough ?

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:928
> +EAPI Eina_Bool ewk_view_use_fixed_layout_get(const Evas_Object *o);

ditto.

[Daniel Juyung Seo]

How about ewk_view_layout_fixed_get/get()?

[Gyuyoung Kim]

(In reply to comment #4)
> How about ewk_view_layout_fixed_get/get()?

If it is more close to efl function naming style, I agree to use it !

[Jinwoo Song]

Created attachment 223426 [details]
Patch

Changed API name as suggested by Daniel and Gyuyoung.

[Gyuyoung Kim]

Comment on attachment 223426 [details]
Patch

LGTM

[WebKit Commit Bot]

Comment on attachment 223426 [details]
Patch

Clearing flags on attachment: 223426

Committed r163614: <http://trac.webkit.org/changeset/163614>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.