WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128118
Manage CalcExpressionNode and derived classes through std::unique_ptr instead of OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=128118
Summary
Manage CalcExpressionNode and derived classes through std::unique_ptr instead...
Zan Dobersek
Reported
2014-02-03 12:53:03 PST
Manage CalcExpressionNode and derived classes through std::unique_ptr instead of OwnPtr
Attachments
Patch
(11.02 KB, patch)
2014-02-03 12:54 PST
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2014-02-03 12:54:49 PST
Created
attachment 223012
[details]
Patch
Darin Adler
Comment 2
2014-02-03 15:54:27 PST
Comment on
attachment 223012
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=223012&action=review
> Source/WebCore/css/CSSCalculationValue.cpp:401 > + std::unique_ptr<CalcExpressionNode> left(m_leftSide->toCalcValue(style, rootStyle, zoom));
Maybe auto here?
> Source/WebCore/css/CSSCalculationValue.cpp:404 > + std::unique_ptr<CalcExpressionNode> right(m_rightSide->toCalcValue(style, rootStyle, zoom));
Maybe auto here?
Zan Dobersek
Comment 3
2014-02-04 10:08:11 PST
Comment on
attachment 223012
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=223012&action=review
>> Source/WebCore/css/CSSCalculationValue.cpp:401 >> + std::unique_ptr<CalcExpressionNode> left(m_leftSide->toCalcValue(style, rootStyle, zoom)); > > Maybe auto here?
I'd rather not -- nothing in 'm_leftSide->toCalcValue(...)' tells me that std::unique_ptr is returned.
>> Source/WebCore/css/CSSCalculationValue.cpp:404 >> + std::unique_ptr<CalcExpressionNode> right(m_rightSide->toCalcValue(style, rootStyle, zoom)); > > Maybe auto here?
Ditto.
Zan Dobersek
Comment 4
2014-02-05 03:15:03 PST
Comment on
attachment 223012
[details]
Patch Clearing flags on attachment: 223012 Committed
r163439
: <
http://trac.webkit.org/changeset/163439
>
Zan Dobersek
Comment 5
2014-02-05 03:15:12 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug