Bug 128118 - Manage CalcExpressionNode and derived classes through std::unique_ptr instead of OwnPtr
Summary: Manage CalcExpressionNode and derived classes through std::unique_ptr instead...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 128007
  Show dependency tree / graph
 
Reported: 2014-02-03 12:53 PST by Zan Dobersek
Modified: 2014-02-05 03:15 PST (History)
7 users (show)

See Also:

Attachments
Patch (11.02 KB, patch)
2014-02-03 12:54 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-02-03 12:53:03 PST 
Manage CalcExpressionNode and derived classes through std::unique_ptr instead of OwnPtr
Comment 1 Zan Dobersek 2014-02-03 12:54:49 PST 
Created attachment 223012 [details]
Patch
Comment 2 Darin Adler 2014-02-03 15:54:27 PST 
Comment on attachment 223012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223012&action=review

> Source/WebCore/css/CSSCalculationValue.cpp:401
> +        std::unique_ptr<CalcExpressionNode> left(m_leftSide->toCalcValue(style, rootStyle, zoom));

Maybe auto here?

> Source/WebCore/css/CSSCalculationValue.cpp:404
> +        std::unique_ptr<CalcExpressionNode> right(m_rightSide->toCalcValue(style, rootStyle, zoom));

Maybe auto here?
Comment 3 Zan Dobersek 2014-02-04 10:08:11 PST 
Comment on attachment 223012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223012&action=review

>> Source/WebCore/css/CSSCalculationValue.cpp:401
>> +        std::unique_ptr<CalcExpressionNode> left(m_leftSide->toCalcValue(style, rootStyle, zoom));
> 
> Maybe auto here?

I'd rather not -- nothing in 'm_leftSide->toCalcValue(...)' tells me that std::unique_ptr is returned.

>> Source/WebCore/css/CSSCalculationValue.cpp:404
>> +        std::unique_ptr<CalcExpressionNode> right(m_rightSide->toCalcValue(style, rootStyle, zoom));
> 
> Maybe auto here?

Ditto.
Comment 4 Zan Dobersek 2014-02-05 03:15:03 PST 
Comment on attachment 223012 [details]
Patch

Clearing flags on attachment: 223012

Committed r163439: <http://trac.webkit.org/changeset/163439>
Comment 5 Zan Dobersek 2014-02-05 03:15:12 PST 
All reviewed patches have been landed.  Closing bug.