RESOLVED FIXED 128042
Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS) 
https://bugs.webkit.org/show_bug.cgi?id=128042
Summary Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS)
Darin Adler
Reported 2014-02-01 08:42:14 PST
Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS)
Attachments
Patch (12.11 KB, patch)
2014-02-01 08:42 PST, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2014-02-01 08:42:44 PST
Created attachment 222882 [details] Patch
Geoffrey Garen
Comment 2 2014-02-01 10:25:01 PST
1>..\platform\win\BString.cpp(84): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString' C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString'
Geoffrey Garen
Comment 3 2014-02-01 10:25:30 PST
1>..\platform\graphics\win\FontCacheWin.cpp(450): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString' C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString' 1>..\platform\graphics\win\FontCacheWin.cpp(450): error C2660: 'memcpy' : function does not take 2 arguments 1>..\platform\graphics\win\FontCacheWin.cpp(532): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString' C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString' 1>..\platform\graphics\win\FontCacheWin.cpp(532): error C2660: 'memcpy' : function does not take 2 arguments
Sam Weinig
Comment 4 2014-02-01 16:05:33 PST
Comment on attachment 222882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222882&action=review > Source/WebCore/platform/win/BString.cpp:84 > + m_bstr = SysAllocStringLen(s.deprecatedCharacters(), s.length()); AtomicString does not have a deprecatedCharacters(), so you need to do a s.string().deprecatedCharacters().
Darin Adler
Comment 5 2014-02-01 20:54:50 PST
Committed r163257: <http://trac.webkit.org/changeset/163257>
Note You need to log in before you can comment on or make changes to this bug.