Bug 128042 - Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS)
Summary: Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 126865
  Show dependency tree / graph
 
Reported: 2014-02-01 08:42 PST by Darin Adler
Modified: 2014-02-01 20:54 PST (History)
4 users (show)

See Also:

Attachments
Patch (12.11 KB, patch)
2014-02-01 08:42 PST, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-02-01 08:42:14 PST 
Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS)
Comment 1 Darin Adler 2014-02-01 08:42:44 PST 
Created attachment 222882 [details]
Patch
Comment 2 Geoffrey Garen 2014-02-01 10:25:01 PST 
     1>..\platform\win\BString.cpp(84): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString'
                 C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString'
Comment 3 Geoffrey Garen 2014-02-01 10:25:30 PST 
     1>..\platform\graphics\win\FontCacheWin.cpp(450): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString'
                 C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString'
     1>..\platform\graphics\win\FontCacheWin.cpp(450): error C2660: 'memcpy' : function does not take 2 arguments
     1>..\platform\graphics\win\FontCacheWin.cpp(532): error C2039: 'deprecatedCharacters' : is not a member of 'WTF::AtomicString'
                 C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/text/AtomicString.h(40) : see declaration of 'WTF::AtomicString'
     1>..\platform\graphics\win\FontCacheWin.cpp(532): error C2660: 'memcpy' : function does not take 2 arguments
Comment 4 Sam Weinig 2014-02-01 16:05:33 PST 
Comment on attachment 222882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222882&action=review

> Source/WebCore/platform/win/BString.cpp:84
> +        m_bstr = SysAllocStringLen(s.deprecatedCharacters(), s.length());

AtomicString does not have a deprecatedCharacters(), so you need to do a s.string().deprecatedCharacters().
Comment 5 Darin Adler 2014-02-01 20:54:50 PST 
Committed r163257: <http://trac.webkit.org/changeset/163257>