Bug 126865 – Obey "delete this" comments, including deleting String::characters and friends

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Darin Adler]

Obey "delete this" comments, including deleting String::characters and friends

[Darin Adler]

Created attachment 220998 [details]
Patch

[Build Bot]

Comment on attachment 220998 [details]
Patch

Attachment 220998 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5184853649653760

[EFL EWS Bot]

Comment on attachment 220998 [details]
Patch

Attachment 220998 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/6319781309317120

[Build Bot]

Comment on attachment 220998 [details]
Patch

Attachment 220998 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4988534721085440

[kov's GTK+ EWS bot]

Comment on attachment 220998 [details]
Patch

Attachment 220998 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/4798223378022400

[Build Bot]

Comment on attachment 220998 [details]
Patch

Attachment 220998 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5928938345857024

[EFL EWS Bot]

Comment on attachment 220998 [details]
Patch

Attachment 220998 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/6291465663676416

[Darin Adler]

Doing this is blocked by redoing the work in bug 126854 or at least renaming the call sites to use deprecatedCharacters.

[Darin Adler]

Created attachment 222238 [details]
Patch

[Darin Adler]

Created attachment 222904 [details]
Patch

[Darin Adler]

Created attachment 222928 [details]
Patch

[Darin Adler]

Created attachment 222957 [details]
Patch

[WebKit Commit Bot]

Attachment 222957 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/text/WTFString.h:115:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 222957 [details]
Patch

Clearing flags on attachment: 222957

Committed r163289: <http://trac.webkit.org/changeset/163289>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

(In reply to comment #14)
> (From update of attachment 222957 [details])
> Clearing flags on attachment: 222957
> 
> Committed r163289: <http://trac.webkit.org/changeset/163289>

This broke builds where ENABLE(DATE_AND_TIME_INPUT_TYPES) is true, such as the iOS build, because BaseDateAndTimeInputType.cpp still uses characters().

[Csaba Osztrogonác]

It broke the WinCairo build too:

     1>..\..\win\WebDownloadCurl.cpp(184): error C2039: 'characters' : is not a member of 'WTF::String'
                 C:\Projects\BuildSlave\win-cairo-release\build\WebKitBuild\Release_WinCairo\Include\private\wtf/text/WTFString.h(84) : see declaration of 'WTF::String'
     1>..\..\win\WebDownloadCurl.cpp(184): error C2664: 'WebCore::BString::BString(const WebCore::BString &)' : cannot convert argument 1 from 'unsigned int' to 'const wchar_t *'
                 Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast

[Darin Adler]

Basically it broke any build without EWS or a buildbot, which is no surprise!