Bug 127903 - Fix the ARM Thumb2 build after jsCStack branch merge
Summary: Fix the ARM Thumb2 build after jsCStack branch merge
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108645 127763
  Show dependency treegraph
 
Reported: 2014-01-30 03:41 PST by Csaba Osztrogonác
Modified: 2014-01-31 10:55 PST (History)
6 users (show)

See Also:


Attachments
proposed patch (3.18 KB, patch)
2014-01-31 07:37 PST, Gabor Rapcsanyi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-01-30 03:41:54 PST
The merge broke the ARM Thumb2 build on Linux.
Here is the error log:

{standard input}: Assembler messages:
{standard input}:63: Error: r13 not allowed here -- `subs sp,r7,#8'
{standard input}:67: Error: r13 not allowed here -- `adds sp,r7,#40'
{standard input}:153: Error: r13 not allowed here -- `adds sp,r7,#40'
{standard input}:207: Error: r13 not allowed here -- `subs sp,r7,#8'
{standard input}:211: Error: r13 not allowed here -- `adds sp,r7,#40'
{standard input}:283: Error: r13 not allowed here -- `adds sp,r7,#40'
{standard input}:357: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:392: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:432: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:511: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:591: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:683: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:759: Error: r13 not allowed here -- `adds sp,r7,#40'
{standard input}:4774: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6707: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6726: Error: r13 not allowed here -- `adds sp,r1,#8'
{standard input}:6733: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6799: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6818: Error: r13 not allowed here -- `adds sp,r1,#8'
{standard input}:6825: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6860: Error: r13 not allowed here -- `subs sp,r1,#8'
{standard input}:6867: Error: r13 not allowed here -- `adds sp,r1,#8'
{standard input}:6874: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6898: Error: r13 not allowed here -- `adds sp,r1,#8'
{standard input}:6905: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:7144: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:7206: Error: r13 not allowed here -- `subs sp,r7,r8'
make[2]: *** [Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LowLevelInterpreter.cpp.o] Error 1
Comment 1 Gabor Rapcsanyi 2014-01-31 07:37:33 PST
Created attachment 222813 [details]
proposed patch
Comment 2 Geoffrey Garen 2014-01-31 08:41:26 PST
Are you sure about this? These instructions compile OK on the Apple ARM Thumb2 build. Michael, can you comment?
Comment 3 Michael Saboff 2014-01-31 10:27:59 PST
(In reply to comment #2)
> Are you sure about this? These instructions compile OK on the Apple ARM Thumb2 build. Michael, can you comment?

It depends on what add or sub instruction the assembler chooses to use as to whether sp is a legal target.  I'm fine with the change.
Comment 4 WebKit Commit Bot 2014-01-31 10:55:18 PST
Comment on attachment 222813 [details]
proposed patch

Clearing flags on attachment: 222813

Committed r163179: <http://trac.webkit.org/changeset/163179>
Comment 5 WebKit Commit Bot 2014-01-31 10:55:20 PST
All reviewed patches have been landed.  Closing bug.