Bug 127903 – Fix the ARM Thumb2 build after jsCStack branch merge

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

The merge broke the ARM Thumb2 build on Linux.
Here is the error log:

{standard input}: Assembler messages:
{standard input}:63: Error: r13 not allowed here -- `subs sp,r7,#8'
{standard input}:67: Error: r13 not allowed here -- `adds sp,r7,#40'
{standard input}:153: Error: r13 not allowed here -- `adds sp,r7,#40'
{standard input}:207: Error: r13 not allowed here -- `subs sp,r7,#8'
{standard input}:211: Error: r13 not allowed here -- `adds sp,r7,#40'
{standard input}:283: Error: r13 not allowed here -- `adds sp,r7,#40'
{standard input}:357: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:392: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:432: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:511: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:591: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:683: Error: r13 not allowed here -- `subs sp,r7,r2'
{standard input}:759: Error: r13 not allowed here -- `adds sp,r7,#40'
{standard input}:4774: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6707: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6726: Error: r13 not allowed here -- `adds sp,r1,#8'
{standard input}:6733: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6799: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6818: Error: r13 not allowed here -- `adds sp,r1,#8'
{standard input}:6825: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6860: Error: r13 not allowed here -- `subs sp,r1,#8'
{standard input}:6867: Error: r13 not allowed here -- `adds sp,r1,#8'
{standard input}:6874: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:6898: Error: r13 not allowed here -- `adds sp,r1,#8'
{standard input}:6905: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:7144: Error: r13 not allowed here -- `subs sp,r7,r8'
{standard input}:7206: Error: r13 not allowed here -- `subs sp,r7,r8'
make[2]: *** [Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LowLevelInterpreter.cpp.o] Error 1

[Gabor Rapcsanyi]

Created attachment 222813 [details]
proposed patch

[Geoffrey Garen]

Are you sure about this? These instructions compile OK on the Apple ARM Thumb2 build. Michael, can you comment?

[Michael Saboff]

(In reply to comment #2)
> Are you sure about this? These instructions compile OK on the Apple ARM Thumb2 build. Michael, can you comment?

It depends on what add or sub instruction the assembler chooses to use as to whether sp is a legal target.  I'm fine with the change.

[WebKit Commit Bot]

Comment on attachment 222813 [details]
proposed patch

Clearing flags on attachment: 222813

Committed r163179: <http://trac.webkit.org/changeset/163179>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.