Bug 127892 - REGRESSION: WebKit2.PageLoadBasic API test is failing
Summary: REGRESSION: WebKit2.PageLoadBasic API test is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Anders Carlsson
URL:
Keywords: Regression
: 127934 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-30 00:13 PST by Alexey Proskuryakov
Modified: 2014-01-31 09:24 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.72 KB, patch)
2014-01-31 09:08 PST, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-01-30 00:13:55 PST
WebKit2.PageLoadBasic is failing on Mountain Lion:

[ RUN      ] WebKit2.PageLoadBasic
/Volumes/Data/slave/mountainlion-debug/build/Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:149: Failure
Value of: WKURLIsEqual(activeUrl.get(), url.get())
  Actual: false
Expected: true

It started to fail in <http://trac.webkit.org/changeset/163037>, although the failure mode has changed since then, so it's possible that more brokenness was introduced while everything was crashing.

Anders, could you please take a look soon?
Comment 1 Anders Carlsson 2014-01-30 11:17:26 PST
Will look at this when I get home to my ML machine.
Comment 2 Alexey Proskuryakov 2014-01-30 11:35:48 PST
What should we do in the meanwhile? Bots are red, and it's the nastiest kind of failure, because it prevents even seeing in a popover what layout tests are failing.
Comment 3 Alexey Proskuryakov 2014-01-30 17:06:54 PST
*** Bug 127934 has been marked as a duplicate of this bug. ***
Comment 4 Alexey Proskuryakov 2014-01-30 17:07:23 PST
Andy disabled the test in <http://trac.webkit.org/changeset/163100>.
Comment 5 Anders Carlsson 2014-01-31 09:08:35 PST
Created attachment 222821 [details]
Patch
Comment 6 Anders Carlsson 2014-01-31 09:22:09 PST
Committed r163173: <http://trac.webkit.org/changeset/163173>
Comment 7 Alexey Proskuryakov 2014-01-31 09:24:17 PST
Comment on attachment 222821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222821&action=review

> Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:111
>  // FIXME: http://webkit.org/b/127934 REGRESSION (r163037): WebKit2.PageLoadBasic API test failing on Mountain Lion

Can you please remove this line too?