Bug 127834 - EventHandler::handleMouseReleaseEvent shouldn't call updateSelectionCachesIfSelectionIsInsideTextFormControl and selectFrameElementInParentIfFullySelected
Summary: EventHandler::handleMouseReleaseEvent shouldn't call updateSelectionCachesIfS...
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on: 127831
Blocks: 127832
  Show dependency treegraph
Reported: 2014-01-29 00:30 PST by Ryosuke Niwa
Modified: 2014-01-29 17:49 PST (History)
5 users (show)

See Also:

Cleanup (8.10 KB, patch)
2014-01-29 01:54 PST, Ryosuke Niwa
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-01-29 00:30:22 PST
It's bogus to call notifyRendererOfSelectionChange and selectFrameElementInParentIfFullySelected in
EventHandler::handleMouseReleaseEvent since setSelection should be calling those functions as needed.

We do this because FrameSelection::setNonDirectionalSelectionIfNeeded doesn't call setSelection with EUserTriggered option :(
Comment 1 Ryosuke Niwa 2014-01-29 01:54:00 PST
Created attachment 222559 [details]
Comment 2 Ryosuke Niwa 2014-01-29 17:49:56 PST
Committed r163056: <http://trac.webkit.org/changeset/163056>