Bug 127831 - Rename notifyRendererOfSelectionChange
Summary: Rename notifyRendererOfSelectionChange
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 127834
  Show dependency tree / graph
 
Reported: 2014-01-28 23:36 PST by Ryosuke Niwa
Modified: 2014-01-29 10:14 PST (History)
6 users (show)

See Also:

Attachments
Cleanup (6.16 KB, patch)
2014-01-29 00:25 PST, Ryosuke Niwa 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-01-28 23:36:44 PST 
notifyRendererOfSelectionChange doesn't notify renderer EVER.

The name comes from the era where shadow DOM was a render tree concept.
The sole purpose of this function is to update text form controls' selection cache so it should be named so.
Comment 1 Ryosuke Niwa 2014-01-29 00:25:53 PST 
Created attachment 222556 [details]
Cleanup
Comment 2 Ryosuke Niwa 2014-01-29 01:27:48 PST 
Committed r163012: <http://trac.webkit.org/changeset/163012>
Comment 3 Darin Adler 2014-01-29 10:14:50 PST 
Comment on attachment 222556 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=222556&action=review

> Source/WebCore/ChangeLog:8
> +        Renamed notifyRendererOfSelectionChange to updateSelectionCachesIfSelectionIsInsideTextFormControl.

I think that the name updateFormControlSelectionCaches would be better.

It’s true that there is nothing to update if the selection is not inside a text form control, but I don’t think that needs to be stated in the function name.