Bug 127501 – IDB: Implement cross-thread and IPC plumbing for 'get' support

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

IDB: Implement cross-thread and IPC plumbing for 'get' support

[Brady Eidson]

Implementing actual backing store support of fetching the record is tracked in https://bugs.webkit.org/show_bug.cgi?id=127502, as this patch can easily be reviewed/landed separately.

[Brady Eidson]

Created attachment 222012 [details]
Patch v1

[WebKit Commit Bot]

Attachment 222012 [details] did not pass style-queue:


ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:434:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:80:  The parameter name "keyRange" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 222012 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=222012&action=review

> Source/WebCore/Modules/indexeddb/IDBKeyRangeData.cpp:43
> +    return std::move(result);

No need for move here.

[Brady Eidson]

http://trac.webkit.org/changeset/162633