RESOLVED FIXED 127502
IDB: Implement SQLite backing store 'get' support 
https://bugs.webkit.org/show_bug.cgi?id=127502
Summary IDB: Implement SQLite backing store 'get' support
Brady Eidson
Reported 2014-01-23 12:07:50 PST
IDB: Implement SQLite backing store 'get' support
Attachments
Patch v1 (20.86 KB, patch)
2014-01-23 17:19 PST, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-01-23 17:19:00 PST
Created attachment 222048 [details] Patch v1
Tim Horton
Comment 2 2014-01-23 19:42:57 PST
Comment on attachment 222048 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=222048&action=review > Source/WebCore/platform/sql/SQLiteDatabase.cpp:511 > + std::function<int(int, const void*, int, const void*)>* f = static_cast<std::function<int(int, const void*, int, const void*)>*>(arg); these seem like one of the canonical "pure win" places to use auto.
Brady Eidson
Comment 3 2014-01-23 19:44:03 PST
(In reply to comment #2) > (From update of attachment 222048 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222048&action=review > > > Source/WebCore/platform/sql/SQLiteDatabase.cpp:511 > > + std::function<int(int, const void*, int, const void*)>* f = static_cast<std::function<int(int, const void*, int, const void*)>*>(arg); > > these seem like one of the canonical "pure win" places to use auto. I agree. thx
Brady Eidson
Comment 4 2014-01-23 19:48:26 PST
http://trac.webkit.org/changeset/162682
Note You need to log in before you can comment on or make changes to this bug.