Bug 127502 - IDB: Implement SQLite backing store 'get' support
Summary: IDB: Implement SQLite backing store 'get' support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 124521
  Show dependency tree / graph
 
Reported: 2014-01-23 12:07 PST by Brady Eidson
Modified: 2014-01-23 19:48 PST (History)
6 users (show)

See Also:

Attachments
Patch v1 (20.86 KB, patch)
2014-01-23 17:19 PST, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-01-23 12:07:50 PST 
IDB: Implement SQLite backing store 'get' support
Comment 1 Brady Eidson 2014-01-23 17:19:00 PST 
Created attachment 222048 [details]
Patch v1
Comment 2 Tim Horton 2014-01-23 19:42:57 PST 
Comment on attachment 222048 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=222048&action=review

> Source/WebCore/platform/sql/SQLiteDatabase.cpp:511
> +    std::function<int(int, const void*, int, const void*)>* f = static_cast<std::function<int(int, const void*, int, const void*)>*>(arg);

these seem like one of the canonical "pure win" places to use auto.
Comment 3 Brady Eidson 2014-01-23 19:44:03 PST 
(In reply to comment #2)
> (From update of attachment 222048 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222048&action=review
> 
> > Source/WebCore/platform/sql/SQLiteDatabase.cpp:511
> > +    std::function<int(int, const void*, int, const void*)>* f = static_cast<std::function<int(int, const void*, int, const void*)>*>(arg);
> 
> these seem like one of the canonical "pure win" places to use auto.

I agree.  thx
Comment 4 Brady Eidson 2014-01-23 19:48:26 PST 
http://trac.webkit.org/changeset/162682