Bug 127215 - FTL mishandles (-2147483648 % 0) | 0
Summary: FTL mishandles (-2147483648 % 0) | 0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2014-01-17 22:14 PST by Filip Pizlo
Modified: 2014-01-30 13:34 PST (History)
9 users (show)

See Also:

Attachments
the patch (2.88 KB, patch)
2014-01-17 22:16 PST, Filip Pizlo 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-01-17 22:14:57 PST 
The refactoring that made the ArithDiv and ArithMod share a common path caused this bug.  I think it's generally not a good idea to try to refactor such boilerplate paths into sharing code.  Every time we do it, we get it wrong.
Comment 1 Filip Pizlo 2014-01-17 22:16:12 PST 
Created attachment 221536 [details]
the patch
Comment 2 Filip Pizlo 2014-01-17 22:28:14 PST 
Landed on branch on http://trac.webkit.org/changeset/162246