patch forthcoming
Created attachment 221405 [details] ArithCos patch
Comment on attachment 221405 [details] ArithCos patch View in context: https://bugs.webkit.org/attachment.cgi?id=221405&action=review > Source/JavaScriptCore/ChangeLog:37 > +2014-01-16 Matthew Mirman <mmirman@apple.com> > + > + ArithSin in FTL > + https://bugs.webkit.org/show_bug.cgi?id=127129 > + > + Reviewed by NOBODY (OOPS!). > + > + * ftl/FTLCapabilities.cpp: > + (JSC::FTL::canCompile): > + * ftl/FTLIntrinsicRepository.h: > + * ftl/FTLLowerDFGToLLVM.cpp: > + (JSC::FTL::LowerDFGToLLVM::compileNode): > + (JSC::FTL::LowerDFGToLLVM::compileArithSin): > + * ftl/FTLOutput.h: > + (JSC::FTL::Output::doubleSin): > + * tests/stress/ftl-arithsin.js: Added. > + You should rebase. ;-)
Comment on attachment 221405 [details] ArithCos patch Looks like you uploaded both cos and sin.
Created attachment 221686 [details] ArithCos Patch
Created attachment 221687 [details] ArithCos patch without the deleted change log
Comment on attachment 221687 [details] ArithCos patch without the deleted change log R=me, I will land.
Landed in http://trac.webkit.org/changeset/162375