Bug 127129 - ArithSin in FTL
Summary: ArithSin in FTL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 127319 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-16 12:12 PST by Matthew Mirman
Modified: 2014-01-20 16:01 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.51 KB, patch)
2014-01-16 12:28 PST, Matthew Mirman 		fpizlo: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Mirman 2014-01-16 12:12:21 PST 
patch forthcoming
Comment 1 Matthew Mirman 2014-01-16 12:28:17 PST 
Created attachment 221401 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-16 12:32:08 PST 
Comment on attachment 221401 [details]
Patch

Rejecting attachment 221401 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 221401, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ToLLVM.cpp
Hunk #1 succeeded at 286 (offset -31 lines).
Hunk #2 succeeded at 1117 (offset -56 lines).
Hunk #3 FAILED at 4310.
1 out of 3 hunks FAILED -- saving rejects to file Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp.rej
patching file Source/JavaScriptCore/ftl/FTLOutput.h
patching file Source/JavaScriptCore/tests/stress/ftl-arithsin.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5417744627400704
Comment 3 Filip Pizlo 2014-01-16 12:34:01 PST 
(In reply to comment #2)
> (From update of attachment 221401 [details])
> Rejecting attachment 221401 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 221401, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit
> 
> Last 500 characters of output:
> ToLLVM.cpp
> Hunk #1 succeeded at 286 (offset -31 lines).
> Hunk #2 succeeded at 1117 (offset -56 lines).
> Hunk #3 FAILED at 4310.
> 1 out of 3 hunks FAILED -- saving rejects to file Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp.rej
> patching file Source/JavaScriptCore/ftl/FTLOutput.h
> patching file Source/JavaScriptCore/tests/stress/ftl-arithsin.js
> 
> Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
> 
> Full output: http://webkit-queues.appspot.com/results/5417744627400704

Oops, right - commit-queue doesn't know how to land on branch.  I will land this myself.
Comment 4 Filip Pizlo 2014-01-16 12:55:26 PST 
Landed in http://trac.webkit.org/changeset/162142
Comment 5 Matthew Mirman 2014-01-20 16:01:05 PST 
*** Bug 127319 has been marked as a duplicate of this bug. ***