Bug 127113 - Allow MediaSessionManager to restrict inline <video> playback
Summary: Allow MediaSessionManager to restrict inline <video> playback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-16 09:08 PST by Eric Carlson
Modified: 2014-01-16 15:03 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch (13.72 KB, patch)
2014-01-16 09:20 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch, now with one less space. (13.72 KB, patch)
2014-01-16 10:06 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-01-16 09:08:16 PST 
Some platforms do not allow a <video> element to play inline. Have MediaSessionManager handle this.
Comment 1 Eric Carlson 2014-01-16 09:20:49 PST 
Created attachment 221382 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2014-01-16 09:23:14 PST 
Attachment 221382 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/media/video-fullscreeen-only-playback-expected.txt', u'LayoutTests/media/video-fullscreeen-only-playback.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaSession.cpp', u'Source/WebCore/html/HTMLMediaSession.h', u'Source/WebCore/platform/audio/MediaSession.h', u'Source/WebCore/platform/audio/MediaSessionManager.cpp', u'Source/WebCore/platform/audio/MediaSessionManager.h', u'Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm', u'Source/WebCore/testing/Internals.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/html/HTMLMediaSession.cpp:130:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Carlson 2014-01-16 10:06:05 PST 
Created attachment 221387 [details]
Updated patch, now with one less space.
Comment 4 Jer Noble 2014-01-16 12:54:49 PST 
Comment on attachment 221387 [details]
Updated patch, now with one less space.

r=me.
Comment 5 WebKit Commit Bot 2014-01-16 13:03:27 PST 
Comment on attachment 221387 [details]
Updated patch, now with one less space.

Rejecting attachment 221387 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 221387, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
r.h
patching file Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm
patching file Source/WebCore/testing/Internals.cpp
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/media/video-fullscreeen-only-playback-expected.txt
patching file LayoutTests/media/video-fullscreeen-only-playback.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5912825708937216
Comment 6 Eric Carlson 2014-01-16 13:23:16 PST 
Committed r162145: https://trac.webkit.org/r162145
Comment 7 Alexey Proskuryakov 2014-01-16 14:12:11 PST 
Looks like media/video-controls-visible-audio-only.html has started to fail after this change (it was flaky before, but now it's failing all the time.

Eric, Jer, will you be available to look into this?

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-controls-visible-audio-only.html
Comment 8 Alexey Proskuryakov 2014-01-16 15:03:37 PST 
Filed bug 127147 about that.