Bug 127147 – REGRESSION(r162145): media/video-controls-visible-audio-only.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Alexey Proskuryakov]

media/video-controls-visible-audio-only.html fails on all Mac bots.

Jer asked to keep this revision in the tree for a while. Not quite sure what the rationale for keeping it is though, would it be hard to investigate offline?

[Alexey Proskuryakov]

Added the test to TestExpectations in <http://trac.webkit.org/r162157>.

Since this change introduced a strange and (yet) inexplicable dependency between tests, and media test failures are by far the #1 contributor to testing instability, my plan is to roll out r162145 later today if fixing it for good proves difficult.

[Jer Noble]

Created attachment 221422 [details]
Patch

[Jer Noble]

Created attachment 221424 [details]
Patch

Now with a re-enabled test.

[Alexey Proskuryakov]

Comment on attachment 221424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221424&action=review

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h:45
> +    virtual void resetRestrictions() OVERRIDE;

This won't build, as we don't have OVERRIDE any more. Please use lower case now.

[Jer Noble]

Created attachment 221425 [details]
Patch for landing

[Jer Noble]

Created attachment 221428 [details]
Patch for landing

Rebaselined

[WebKit Commit Bot]

Comment on attachment 221428 [details]
Patch for landing

Rejecting attachment 221428 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 221428, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5734015281659904

[Jer Noble]

Committed r162178: <http://trac.webkit.org/changeset/162178>