Bug 127147 - REGRESSION(r162145): media/video-controls-visible-audio-only.html fails
Summary: REGRESSION(r162145): media/video-controls-visible-audio-only.html fails
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
Depends on:
Reported: 2014-01-16 14:53 PST by Alexey Proskuryakov
Modified: 2014-01-16 18:08 PST (History)
4 users (show)

See Also:

Patch (5.28 KB, patch)
2014-01-16 16:02 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (6.47 KB, patch)
2014-01-16 16:14 PST, Jer Noble
eric.carlson: review+
ap: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (6.47 KB, patch)
2014-01-16 16:41 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (6.72 KB, patch)
2014-01-16 17:06 PST, Jer Noble
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-01-16 14:53:10 PST
media/video-controls-visible-audio-only.html fails on all Mac bots.

Jer asked to keep this revision in the tree for a while. Not quite sure what the rationale for keeping it is though, would it be hard to investigate offline?
Comment 1 Alexey Proskuryakov 2014-01-16 15:00:14 PST
Added the test to TestExpectations in <http://trac.webkit.org/r162157>.

Since this change introduced a strange and (yet) inexplicable dependency between tests, and media test failures are by far the #1 contributor to testing instability, my plan is to roll out r162145 later today if fixing it for good proves difficult.
Comment 2 Jer Noble 2014-01-16 16:02:44 PST
Created attachment 221422 [details]
Comment 3 Jer Noble 2014-01-16 16:14:19 PST
Created attachment 221424 [details]

Now with a re-enabled test.
Comment 4 Alexey Proskuryakov 2014-01-16 16:23:39 PST
Comment on attachment 221424 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=221424&action=review

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h:45
> +    virtual void resetRestrictions() OVERRIDE;

This won't build, as we don't have OVERRIDE any more. Please use lower case now.
Comment 5 Jer Noble 2014-01-16 16:41:18 PST
Created attachment 221425 [details]
Patch for landing
Comment 6 Jer Noble 2014-01-16 17:06:36 PST
Created attachment 221428 [details]
Patch for landing

Comment 7 WebKit Commit Bot 2014-01-16 18:02:21 PST
Comment on attachment 221428 [details]
Patch for landing

Rejecting attachment 221428 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 221428, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5734015281659904
Comment 8 Jer Noble 2014-01-16 18:08:46 PST
Committed r162178: <http://trac.webkit.org/changeset/162178>