While working on another bug, I noticed that the error messages we generate for linker errors for our shaders reports the mapped symbol name (i.e., the mangled ANGLE name). We should use the actual variable name from the source file when reporting a problem to the user. Instead of this: [Log] *** Error linking program '[object WebGLProgram]':ERROR: Input of fragment shader 'webgl_a78e73e400000001' not written by vertex shader (glsl-conformance-test.js, line 44) We should report: [Log] *** Error linking program '[object WebGLProgram]':ERROR: Input of fragment shader 'v_varying' not written by vertex shader (glsl-conformance-test.js, line 44)
<rdar://problem/15800348>
While working on this issue I discovered that we were not building a symbol table for varyings, and that the encoder would crash when asked to process a varying because of a missing 'break'.
Created attachment 220961 [details] Patch
Attachment 220961 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/canvas/webgl/glsl-conformance-expected.txt', u'LayoutTests/fast/canvas/webgl/glsl-conformance.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp', u'Source/WebCore/platform/graphics/GraphicsContext3D.h', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1347: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1349: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1347: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1349: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 4 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 220961 [details] Patch Attachment 220961 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/6046675881689088
This bug was introduced by http://trac.webkit.org/changeset/156352, when we turned on the ANGLE name mangling.
Created attachment 220963 [details] Revised to help EFL/GTK to build properly
Attachment 220963 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/canvas/webgl/glsl-conformance-expected.txt', u'LayoutTests/fast/canvas/webgl/glsl-conformance.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp', u'Source/WebCore/platform/graphics/GraphicsContext3D.h', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1347: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1349: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1347: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1349: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 4 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 220963 [details] Revised to help EFL/GTK to build properly Attachment 220963 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/6202724660019200
Comment on attachment 220963 [details] Revised to help EFL/GTK to build properly View in context: https://bugs.webkit.org/attachment.cgi?id=220963&action=review > Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp:63 > case SH_VARYINGS: > symbolMaxNameLengthType = SH_VARYING_MAX_LENGTH; > + break; Ouch! :)
(In reply to comment #9) > (From update of attachment 220963 [details]) > Attachment 220963 [details] did not pass efl-wk2-ews (efl-wk2): > Output: http://webkit-queues.appspot.com/results/6202724660019200 The error is not related to this patch: [ 19%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/JSOESElementIndexUint.cpp.o c++: internal compiler error: Killed (program cc1plus) Please submit a full bug report,
Committed r161843: <http://trac.webkit.org/changeset/161843>
Re-opened since this is blocked by bug 126871
Committed r161889: <http://trac.webkit.org/changeset/161889>