Bug 126743 - [CSSRegions] Disable accelerated compositing for fixed elements in regions tests
Summary: [CSSRegions] Disable accelerated compositing for fixed elements in regions tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihnea Ovidenie
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-10 02:29 PST by Mihnea Ovidenie
Modified: 2014-01-10 04:43 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.93 KB, patch)
2014-01-10 03:02 PST, Mihnea Ovidenie
no flags Details | Formatted Diff | Diff
Patch for landing (5.35 KB, patch)
2014-01-10 04:09 PST, Mihnea Ovidenie
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihnea Ovidenie 2014-01-10 02:29:02 PST
Disable accelerated compositing for fixed positioned elements in tests in fast/regions as it is not supported yet. We will add tests with compositing for fixed positioned elements under compositing/regions. This also allows to model the expected files to closer match the behavior in reference files.
Comment 1 Mihnea Ovidenie 2014-01-10 03:02:45 PST
Created attachment 220826 [details]
Patch
Comment 2 Dirk Schulze 2014-01-10 03:04:45 PST
(In reply to comment #0)
> Disable accelerated compositing for fixed positioned elements in tests in fast/regions as it is not supported yet. We will add tests with compositing for fixed positioned elements under compositing/regions. This also allows to model the expected files to closer match the behavior in reference files.

Is there a bug for adding the support already? If not, could you create one and add the link to the change log please?
Comment 3 Dirk Schulze 2014-01-10 03:05:26 PST
Comment on attachment 220826 [details]
Patch

See previous comment.
Comment 4 Mihnea Ovidenie 2014-01-10 03:54:35 PST
(In reply to comment #2)
> (In reply to comment #0)
> > Disable accelerated compositing for fixed positioned elements in tests in fast/regions as it is not supported yet. We will add tests with compositing for fixed positioned elements under compositing/regions. This also allows to model the expected files to closer match the behavior in reference files.
> 
> Is there a bug for adding the support already? If not, could you create one and add the link to the change log please?

Thanks for the review. I will mention https://bugs.webkit.org/show_bug.cgi?id=125144 in the changelog.
Comment 5 Mihnea Ovidenie 2014-01-10 04:09:05 PST
Created attachment 220832 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2014-01-10 04:43:28 PST
Comment on attachment 220832 [details]
Patch for landing

Clearing flags on attachment: 220832

Committed r161631: <http://trac.webkit.org/changeset/161631>
Comment 7 WebKit Commit Bot 2014-01-10 04:43:31 PST
All reviewed patches have been landed.  Closing bug.