126406 – [WebGL2] Update IDL for WebGL2

Bug 126406 - [WebGL2] Update IDL for WebGL2

Summary: [WebGL2] Update IDL for WebGL2

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebGL (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Dean Jackson

URL:
Keywords:	InRadar

Depends on:
Blocks:	126404
	Show dependency tree / graph

Reported:	2014-01-02 14:36 PST by Dean Jackson
Modified:	2015-01-26 14:09 PST (History)
CC List:	6 users (show)

See Also:

Attachments
patch (71.42 KB, patch) 2015-01-26 11:57 PST, Roger Fong	no flags	Details \| Formatted Diff \| Diff
patch (71.37 KB, patch) 2015-01-26 12:52 PST, Roger Fong	no flags	Details \| Formatted Diff \| Diff
patch (71.36 KB, patch) 2015-01-26 13:03 PST, Roger Fong	bfulgham: review+	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dean Jackson 2014-01-02 14:36:31 PST

The WebGL2 spec has some new NoInterface objects to manage inheritance. We need a new interface for the WebGL context, but it would be nice if we could share stuff between the 1 and 2 objects.

Comment 1 Dean Jackson 2014-01-02 14:37:03 PST

<rdar://problem/15002268>

Comment 2 Radar WebKit Bug Importer 2014-01-02 14:37:25 PST

<rdar://problem/15740654>

Comment 3 Roger Fong 2015-01-26 11:57:50 PST

Created attachment 245365 [details]
patch

Comment 4 WebKit Commit Bot 2015-01-26 11:59:10 PST

Attachment 245365 [details] did not pass style-queue:


ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:46:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:76:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:79:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:80:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:81:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:82:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:83:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:84:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:85:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:86:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:87:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:88:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:89:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:90:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:91:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:92:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:114:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:115:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:116:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:119:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:123:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:124:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:125:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:126:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:127:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:128:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:132:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:133:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:134:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:135:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:136:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:145:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:146:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:151:  The parameter name "buffer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:152:  The parameter name "buffer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:152:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:154:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:155:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:156:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:157:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:158:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:159:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:163:  The parameter name "vertexArray" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:164:  The parameter name "vertexArray" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:165:  The parameter name "vertexArray" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 45 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Roger Fong 2015-01-26 12:00:08 PST

I've already dealt with sharing stuff between the webgl1 and 2 objects in a previous patch. This bug now keeps track of just updating the webgl2 idl and providing method stubs as necessary.

Comment 6 Roger Fong 2015-01-26 12:52:08 PST

Created attachment 245367 [details]
patch

w/speculative ios build fix

Comment 7 WebKit Commit Bot 2015-01-26 12:53:53 PST

Attachment 245367 [details] did not pass style-queue:


ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:76:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:79:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:80:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:81:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:82:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:83:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:84:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:85:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:86:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:87:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:88:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:89:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:90:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:91:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:92:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:114:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:115:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:116:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:119:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:123:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:124:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:125:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:126:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:127:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:128:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:132:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:133:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:134:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:135:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:136:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:145:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:146:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:151:  The parameter name "buffer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:152:  The parameter name "buffer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:154:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:155:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:156:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:157:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:158:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:159:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:163:  The parameter name "vertexArray" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:164:  The parameter name "vertexArray" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:165:  The parameter name "vertexArray" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 43 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 8 Roger Fong 2015-01-26 13:03:19 PST

Created attachment 245369 [details]
patch

Comment 9 WebKit Commit Bot 2015-01-26 13:06:09 PST

Attachment 245369 [details] did not pass style-queue:


ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:76:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:79:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:80:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:81:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:82:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:83:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:84:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:85:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:86:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:87:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:88:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:89:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:90:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:91:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:92:  The parameter name "location" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:114:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:115:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:116:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:119:  The parameter name "query" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:123:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:124:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:125:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:126:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:127:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:128:  The parameter name "sampler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:132:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:133:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:134:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:135:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:136:  The parameter name "sync" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:145:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:146:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:151:  The parameter name "buffer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:152:  The parameter name "buffer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:154:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:155:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:156:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:157:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:158:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:159:  The parameter name "program" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:163:  The parameter name "vertexArray" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:164:  The parameter name "vertexArray" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/canvas/WebGL2RenderingContext.h:165:  The parameter name "vertexArray" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 43 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 10 Brent Fulgham 2015-01-26 13:51:57 PST

Comment on attachment 245369 [details]
patch

r=me.

Comment 11 Roger Fong 2015-01-26 14:09:25 PST

http://trac.webkit.org/changeset/179142