Bug 126291 - [SOUP] Implement ResourceHandle::continueWillSendRequest()
Summary: [SOUP] Implement ResourceHandle::continueWillSendRequest()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Soup
Depends on: 126290
Blocks: 126114
  Show dependency treegraph
 
Reported: 2013-12-30 08:10 PST by Carlos Garcia Campos
Modified: 2013-12-31 00:26 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.19 KB, patch)
2013-12-30 08:13 PST, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-12-30 08:10:24 PST
This is needed to support willSendRequest() after a redirection when using network process.

$ WEBKIT_USE_NETWORK_PROCESS=1 Programs/WebKit2APITests/TestResources -p /webkit2/WebKitWebPage/send-request
/webkit2/WebKitWebPage/send-request: **
ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp:585:virtual void SendRequestTest::resourceFailed(WebKitWebResource*, GError*): assertion failed (webkit_web_resource_get_uri(resource) == m_expectedCancelledResourceURI.data()): ("http://127.0.0.1:41610/javascript.js" == "http://127.0.0.1:41610/cancel-this.js")

This is the result of the test after applying patch attached to bug #126290
Comment 1 Carlos Garcia Campos 2013-12-30 08:13:09 PST
Created attachment 220110 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-12-30 08:13:46 PST
$ WEBKIT_USE_NETWORK_PROCESS=1 Programs/WebKit2APITests/TestResources -p /webkit2/WebKitWebPage/send-request
/webkit2/WebKitWebPage/send-request: OK
Comment 3 Carlos Garcia Campos 2013-12-31 00:26:54 PST
Committed r161177: <http://trac.webkit.org/changeset/161177>