Bug 126114 - [SOUP] ResourceHandle doesn't implement continueShouldUseCredentialStorage()
Summary: [SOUP] ResourceHandle doesn't implement continueShouldUseCredentialStorage()
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Soup
Depends on: 126131 126291
  Show dependency treegraph
Reported: 2013-12-21 00:44 PST by Carlos Garcia Campos
Modified: 2014-05-04 01:35 PDT (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-12-21 00:44:51 PST
Clients using the async methods like willSendRequestAsync or didReceiveResponseAsync use a method to continue like continueWillSendRequest or continueDidReceiveResponse. We are not implementing those yet, even though nwe are calling the async methods. In the case of willSendRequest it's clear we need to implement continueWillSendRequest because the request might have changed, but in the other cases we still don't know whether they are required or not.
Comment 1 Carlos Garcia Campos 2013-12-27 03:14:04 PST
Found a use case where continueDidReceiveResponse is required, when the main resource load is converted into a download by the policy checker. Patch attached to bug #126131 implements continueDidReceiveResponse.
Comment 2 Carlos Garcia Campos 2013-12-31 01:35:37 PST
continueWillSendRequest() is now implemented too, so I'm renaming the bug.
Comment 3 Pratik Solanki 2014-05-03 17:19:36 PDT
My fix for bug 132308 (r168232) removed the continueShouldUseCredentialStorage() call. I think there's anything more to do in this bug now.
Comment 4 Pratik Solanki 2014-05-03 17:20:09 PDT
(In reply to comment #3)
> I think there's anything more to do in this bug now.

I mean.. I don't think there's anything more to do in this bug now.