WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126222
REGRESSION(
r160959
): Caused Windows build to fail (Requested by rfong on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=126222
Summary
REGRESSION(r160959): Caused Windows build to fail (Requested by rfong on #web...
WebKit Commit Bot
Reported
2013-12-24 12:59:01 PST
http://trac.webkit.org/changeset/160959
broke the build: Caused Windows build to fail (Requested by rfong on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r160959
(5.46 KB, patch)
2013-12-24 12:59 PST
,
WebKit Commit Bot
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1
2013-12-24 12:59:23 PST
Created
attachment 219980
[details]
ROLLOUT of
r160959
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Roger Fong
Comment 2
2013-12-24 13:00:48 PST
This caused a large chain of Windows build failures. I think that the new <thread> include awakened some demons in the VS2013 headers. Fixed up JavaScriptCore only to reveal another few hundred errors in WebCore. Rolling out the patch for now until a fix. Will rollout the rollout once I do.
WebKit Commit Bot
Comment 3
2013-12-24 13:02:54 PST
Comment on
attachment 219980
[details]
ROLLOUT of
r160959
Clearing flags on attachment: 219980 Committed
r161060
: <
http://trac.webkit.org/changeset/161060
>
WebKit Commit Bot
Comment 4
2013-12-24 13:02:59 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug