Bug 126222 - REGRESSION(r160959): Caused Windows build to fail (Requested by rfong on #webkit).
Summary: REGRESSION(r160959): Caused Windows build to fail (Requested by rfong on #web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 126105
  Show dependency tree / graph
 
Reported: 2013-12-24 12:59 PST by WebKit Commit Bot
Modified: 2013-12-24 13:02 PST (History)
3 users (show)

See Also:

Attachments
ROLLOUT of r160959 (5.46 KB, patch)
2013-12-24 12:59 PST, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2013-12-24 12:59:01 PST 
http://trac.webkit.org/changeset/160959 broke the build:
Caused Windows build to fail (Requested by rfong on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2013-12-24 12:59:23 PST 
Created attachment 219980 [details]
ROLLOUT of r160959

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Roger Fong 2013-12-24 13:00:48 PST 
This caused a large chain of Windows build failures.

I think that the new <thread> include awakened some demons in the VS2013 headers.
Fixed up JavaScriptCore only to reveal another few hundred errors in WebCore.

Rolling out the patch for now until a fix. 
Will rollout the rollout once I do.
Comment 3 WebKit Commit Bot 2013-12-24 13:02:54 PST 
Comment on attachment 219980 [details]
ROLLOUT of r160959

Clearing flags on attachment: 219980

Committed r161060: <http://trac.webkit.org/changeset/161060>
Comment 4 WebKit Commit Bot 2013-12-24 13:02:59 PST 
All reviewed patches have been landed.  Closing bug.